Skip to content

Conversation

@ki-met-hoon
Copy link
Collaborator

Pull request

Related issue

Motivation and context

  • 비정상 종료(새로고침, 강제 종료) 시 서버 내에서 StompCommand.DISCONNECT를 감지하지 못함
  • 이로 인해 삭제되어야 하는 session 관련 key가 지속적으로 존재함
  • 이를 해결하기 위해 handleWebSocketDisconnectListener를 구현해 DISCONNECT Event 자체를 감지해서 handleDisconnection method를 실행해 해결

Solution

How has this been tested

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the docs/CONTRIBUTING.md document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@ki-met-hoon ki-met-hoon added 🐛 BugFix 버그 수정 🎮 BE 백엔드 무조건 스프린트내에 해야하는 것들 labels Feb 19, 2025
@ki-met-hoon ki-met-hoon self-assigned this Feb 19, 2025
@netlify
Copy link

netlify bot commented Feb 19, 2025

Deploy Preview for jootalkpia canceled.

Name Link
🔨 Latest commit eac9e6d
🔍 Latest deploy log https://app.netlify.com/sites/jootalkpia/deploys/67b5ab21b46dda0008058119

Copy link
Member

@bo-ram-bo-ram bo-ram-bo-ram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다!
workspace_server.gradle 하위 파일은 삭제해주세요!

handleStompCommand(StompHeaderAccessor.wrap(message));
}

@Transactional
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이건 왜 제거하셨을까여?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@transactional은 저번 PR에서 말씀 주신 부분을 고려 중이라 현재는 삭제한 상태입니다.
RDB의 경우 SAVE라 필요가 없고 Redis의 경우 Rollback은 안되고 같은 커넥션의 공유로 인한 리소스 절약이 주된 이유라 생각해 Redis의 원자성에 대해 학습 후 반영하겠습니다.

@ki-met-hoon ki-met-hoon merged commit e95351f into dev Feb 20, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

무조건 스프린트내에 해야하는 것들 🎮 BE 백엔드 🐛 BugFix 버그 수정

Projects

None yet

Development

Successfully merging this pull request may close these issues.

WS 비정상 종료에 대한 상태 관리 Redis 관리 버그

3 participants