채널 UnSubscribe 및 DisConnect 시 Last Read Message ID 저장 #231
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- 모든 인덱스 생성이 자동으로 백그라운드에서 수행
- `allow-bean-definition-overriding: true`은 JpaRepository와 MongoRepository 충돌로 인한 코드 추가
✅ Deploy Preview for jootalkpia canceled.
|
bo-ram-bo-ram
approved these changes
Feb 18, 2025
Member
bo-ram-bo-ram
left a comment
bo-ram-bo-ram
left a comment
There was a problem hiding this comment.
고생하셨습니다! update를 통한 성능 개선 굿 떰업
| handleStompCommand(StompHeaderAccessor.wrap(message)); | ||
| } | ||
|
|
||
| public void handleChatUnsubscription(StompHeaderAccessor accessor) { |
Member
There was a problem hiding this comment.
해당 메서드 @transactional처리 안해줘도 될까요?
updateChannelFromSession, removeTabFromChannel, updateLastReadId 3개의 변경이 발생되고 있어서요!
하나라도 실패해도 될까요?
Collaborator
Author
There was a problem hiding this comment.
현재 Redis 트랜잭션, 보상 트랜잭션 등 다양한 방안을 검토 중입니다!
추후에 리팩토링하겠습니다!
| String sql = "UPDATE user_channel SET last_read_id = ? " + | ||
| "WHERE user_id = ? AND channel_id = ?"; | ||
|
|
||
| jdbcTemplate.update(sql, lastReadId, Long.valueOf(userId), Long.valueOf(channelId)); |
Member
There was a problem hiding this comment.
updateLastReadId가 실행될 때 해당 row가 DB에 존재하는지 보장되지 않아서 존재하지 않으면 아무 일도 안 일어날텐데 예외처리까지는 너무 과할까요?
Collaborator
Author
There was a problem hiding this comment.
Optional 추가했고 없을 시 Default 값으로 0L 등록 로직 구현 완료했습니다!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request
Related issue
Motivation and context
handleUserDisconnection내handleChatUnsubscriptionmethod 추가Solution
How has this been tested
Types of changes
Checklist