파일서버: 파일 다운로드&프로필이미지 수정 구현 #152
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for jootalkpia canceled.
|
ki-met-hoon
reviewed
Feb 7, 2025
| ValidationUtils.validateFileId(fileId); | ||
|
|
||
| ResponseInputStream<GetObjectResponse> s3InputStream = fileService.downloadFile(fileId); | ||
|
|
Collaborator
There was a problem hiding this comment.
저는 Controller가 데이터를 전달하는 책임만 가지는 것이 좋다라고 생각해서
다음 비즈니스 로직을 Service단 또는 다른 class로 옮기는 것이 어떠신가요?
| import lombok.AllArgsConstructor; | ||
| import lombok.Data; | ||
|
|
||
| @Data |
Collaborator
There was a problem hiding this comment.
미르님이 안좋다면서요 Data 쓰는거요ㅠㅠㅠ
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request
Related issue
#120
Motivation and context
[청크 없는 초기 방식입니다.]
파일 업로드 로직 보완
파일 다운로드 로직 구현
프로필 이미지 수정 로직 구현
Solution
How has this been tested
Types of changes
Checklist