Skip to content

Conversation

@handje
Copy link
Collaborator

@handje handje commented Feb 6, 2025

Pull request

Related issue

Resolve #103 @handje
Resolve #147 @handje

Motivation and context

  1. 주식리스트 검색바 구현
  2. 주식리스트 열 선택 드롭메뉴 구현

Solution

@KimKyuHoi 이슈를 분리하였지만, 하나로 묶을 수 있다고 판단하여 하나의 pr로 작성하였습니다.

  1. 검색바에 입력하자마자 해당하는 정보만 필터링됩니다.
  2. 종목명을 제외하고 열을 선택할 수 있습니다.
  3. 결과에 따라 테이블이 움직이는 것을 방지하기위해 고정된 사이즈를 사용하였습니다.
  4. 차트 내부 스타일링은 실제 데이터 연결 후, 진행할 예정입니다.

How has this been tested

image

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the docs/CONTRIBUTING.md document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@handje handje changed the title Fe feat/stock list dropdown 주식테이블 검색바, 드롭다운 구현 Feb 6, 2025
@netlify
Copy link

netlify bot commented Feb 6, 2025

Deploy Preview for jootalkpia ready!

Name Link
🔨 Latest commit aa27fd7
🔍 Latest deploy log https://app.netlify.com/sites/jootalkpia/deploys/67a4a742b7a4cf00086c63b4
😎 Deploy Preview https://deploy-preview-149--jootalkpia.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@handje handje requested a review from KimKyuHoi February 6, 2025 12:14
@handje handje self-assigned this Feb 6, 2025
@handje handje added ✨ Feature 기능 추가 💄 Design 프론트엔드 CSS 관련 이슈 🖥️ FE 프론트엔드 무조건 스프린트내에 해야하는 것들 labels Feb 6, 2025
@handje handje added this to the 주톡피아 마일스톤2 milestone Feb 6, 2025
Copy link
Collaborator

@KimKyuHoi KimKyuHoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 👍 👍

@handje handje merged commit 4c057ca into dev Feb 7, 2025
6 checks passed
@handje handje deleted the fe-feat/stock-list-dropdown branch February 7, 2025 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

무조건 스프린트내에 해야하는 것들 💄 Design 프론트엔드 CSS 관련 이슈 🖥️ FE 프론트엔드 ✨ Feature 기능 추가

Projects

None yet

Development

Successfully merging this pull request may close these issues.

주식리스트 드롭다운 적용 주식 리스트 검색바

3 participants