Skip to content

Conversation

@handje
Copy link
Collaborator

@handje handje commented Feb 6, 2025

Pull request

Related issue

Resolve #104 @handje

Motivation and context

  1. 주식 리스트에 사용할 드롭다운 메뉴 디자인시스템 구현

Solution

  1. shadcn 드롭다운 메뉴 사용
  2. 사용될 수 있는 체크박스, 서브메뉴, sepearate 예시로 문서화

How has this been tested

위에서 3가지 (panel)까지는 체크박스 아래는 단순선택 list 입니다.
image

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the docs/CONTRIBUTING.md document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@handje handje requested a review from KimKyuHoi February 6, 2025 04:57
@handje handje self-assigned this Feb 6, 2025
@netlify
Copy link

netlify bot commented Feb 6, 2025

Deploy Preview for jootalkpia ready!

Name Link
🔨 Latest commit 8868bbf
🔍 Latest deploy log https://app.netlify.com/sites/jootalkpia/deploys/67a4414b31dd600008fd94a3
😎 Deploy Preview https://deploy-preview-146--jootalkpia.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@handje handje added ✨ Feature 기능 추가 💄 Design 프론트엔드 CSS 관련 이슈 🖥️ FE 프론트엔드 무조건 스프린트내에 해야하는 것들 labels Feb 6, 2025
@handje handje added this to the 주톡피아 마일스톤2 milestone Feb 6, 2025
Copy link
Collaborator

@KimKyuHoi KimKyuHoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 👍 👍 👍 👍

@handje handje merged commit 778f426 into dev Feb 6, 2025
8 checks passed
@handje handje deleted the fe-feat/dropdown-menu branch February 6, 2025 06:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

무조건 스프린트내에 해야하는 것들 💄 Design 프론트엔드 CSS 관련 이슈 🖥️ FE 프론트엔드 ✨ Feature 기능 추가

Projects

None yet

Development

Successfully merging this pull request may close these issues.

디자인시스템 드롭다운 메뉴 구현

3 participants