-
Notifications
You must be signed in to change notification settings - Fork 3
허들레이아웃 구현 #133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
허들레이아웃 구현 #133
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KimKyuHoi
reviewed
Feb 4, 2025
src/frontend/apps/web/src/features/video/ui/huddle-controls.tsx
Outdated
Show resolved
Hide resolved
src/frontend/apps/web/src/features/video/ui/huddle-controls.tsx
Outdated
Show resolved
Hide resolved
src/frontend/apps/web/src/features/video/ui/huddle-controls.tsx
Outdated
Show resolved
Hide resolved
src/frontend/apps/web/src/features/video/ui/controls-container.tsx
Outdated
Show resolved
Hide resolved
✅ Deploy Preview for cosmic-caramel-c18fcd ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Collaborator
Author
|
Item컴포넌트 분리 및, Reducer적용 하였습니다. 더 좋은 방법이 있다면 말씀해주세요 :) |
KimKyuHoi
reviewed
Feb 6, 2025
src/frontend/apps/web/src/features/video/model/huddle-controls-reducer.ts
Show resolved
Hide resolved
src/frontend/apps/web/src/features/video/model/huddle-controls-reducer.ts
Show resolved
Hide resolved
KimKyuHoi
approved these changes
Feb 7, 2025
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
✅ Deploy Preview for jootalkpia ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request
Related issue
Resolve #63 @handje
Motivation and context
Solution
@KimKyuHoi 아래는 수정된 내용에 대한 설명입니다.
useReducer사용
조건부렌더링 아이콘 객체로 관리 후, group컴포넌트에서 사용
How has this been tested
/huddle 경로에서 테스트 가능합니다. 해당 페이지는 레이아웃 구현 후 삭제 예정입니다.
전체화면

토글 버튼 선택

화면이 작아질 경우 아바타 배치

Types of changes
Checklist