Skip to content

Conversation

@handje
Copy link
Collaborator

@handje handje commented Feb 4, 2025

Pull request

Related issue

Resolve #100 @handje

Motivation and context

  • git action 에러 해결
    image

Solution

  • render내부의 state 삭제
  • toggle variant적용을 보여주기 위한 스타일링 추가

How has this been tested

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the docs/CONTRIBUTING.md document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@handje handje self-assigned this Feb 4, 2025
@handje handje added 🐛 BugFix 버그 수정 🖥️ FE 프론트엔드 무조건 스프린트내에 해야하는 것들 labels Feb 4, 2025
@handje handje requested a review from KimKyuHoi February 4, 2025 02:38
@handje handje added this to the 주톡피아 마일스톤2 milestone Feb 4, 2025
Copy link
Collaborator

@KimKyuHoi KimKyuHoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

나머진 고생많으셨습니다 approve는 할 예정이라서 수정 후 머지하시면 될 것 같습니다.

@handje handje merged commit b087d69 into dev Feb 5, 2025
2 checks passed
@handje handje deleted the fe-fix/storybook-git-action branch February 7, 2025 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

무조건 스프린트내에 해야하는 것들 🐛 BugFix 버그 수정 🖥️ FE 프론트엔드

Projects

None yet

Development

Successfully merging this pull request may close these issues.

git action storybook warning fix

3 participants