WebRtc mvp 구현 #108
Merged
WebRtc mvp 구현 #108
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ki-met-hoon
approved these changes
Feb 3, 2025
Collaborator
ki-met-hoon
left a comment
ki-met-hoon
left a comment
There was a problem hiding this comment.
미르님 WebRTC 구현하시느라 너무 힘드셨는데 너무 고생 많으셨어요!!
추가적으로 root Dir이 signaling_server라 아래 도메인 디렉토리에 sever는 빼셔도 되지 않을까요!?
| import java.util.HashSet; | ||
| import java.util.Set; | ||
|
|
||
| @Data |
Collaborator
There was a problem hiding this comment.
Data 어노테이션의 단점이 있다고 하셨던 것 같은데 Data를 쓰신 이유가 있나요??
만약 Setter가 필요하다면 record로 변경하시는 것도 좋은 방법인 것 같습니다!
| private final KurentoManager kurentoManager; | ||
|
|
||
| @Override | ||
| public void handleTextMessage(WebSocketSession session, TextMessage message) throws IOException { |
Collaborator
There was a problem hiding this comment.
이 부분 switch문으로 하기 보단 enum으로 분리하던가 또는 MessageHandler interface를 만들어서 아래 method들을 Overriding하는게 확장성과 결합도 측면에서 더 나아보이는데 어떻게 생각하시나요??
Member
Author
There was a problem hiding this comment.
고려해보고 다음 pr에 반영하도록 검토하겠습니다!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request
Related issue
#58
Motivation and context
허들 방 생성, 참가, 나가기 구현-(완)
시그널링 구현-(완)
설정파일 적용하여 Coturn docker로 실행-(완)
설정파일 적용하여 Kurento Media Server docker로 실행-(완)
추가 필요한 기능
화면공유
배포 환경에 맞는 Kurento, Coturn 설정
코드 내 에러처리, 유효성 검증 로직
Redis로 허들 데이터 관리
Solution
내부 호스트:포트로 Coturn 동작 및 Kurento 동작 확인하였습니다.
How has this been tested
임시 클라이언트 코드 작성하여 일부 테스트하였습니다.
(ICE 후보 관련 보완 필요)
코턴 Trickle ICE 테스트 결과
Types of changes
Checklist