-
Notifications
You must be signed in to change notification settings - Fork 3
상세페이지 주식부분 레이아웃 #106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
상세페이지 주식부분 레이아웃 #106
Changes from 5 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
cb1f231
#101 feat(fe): 상세페이지 주식레이아웃 상세구현
handje 4ba2578
#101 feat(fe): 주식차트 레이아웃 분리 및 스타일링
handje 47f2ebf
#101 feat(fe): 주식정보 레이아웃 분리
handje 59f9361
#101 feat(fe): 주식정보 상세 정보 구현
handje 2871c4a
#101 fix(fe): 주식상세 전체 레이아웃 및 스타일 수정"
handje 7c61b7d
#101 fix(fe): overflow방지 스타일링 수정
handje File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
28 changes: 28 additions & 0 deletions
28
src/frontend/apps/web/src/features/stock/ui/stock-chart-container.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,28 @@ | ||
| import { | ||
| ResizableHandle, | ||
| ResizablePanel, | ||
| ResizablePanelGroup, | ||
| } from '@workspace/ui/components'; | ||
|
|
||
| const StockChartContainer = () => { | ||
| return ( | ||
| <> | ||
| <ResizablePanelGroup direction="vertical"> | ||
| <ResizablePanel | ||
| defaultSize={30} | ||
| className="flex items-center justify-center bg-gray-200 p-4" | ||
| > | ||
| 주식차트 | ||
| </ResizablePanel> | ||
| <ResizableHandle withHandle /> | ||
| <ResizablePanel | ||
| defaultSize={10} | ||
| className="flex items-center justify-center bg-gray-300 p-4" | ||
| > | ||
| 거래량 캔들차트 | ||
| </ResizablePanel> | ||
| </ResizablePanelGroup> | ||
| </> | ||
| ); | ||
| }; | ||
| export default StockChartContainer; | ||
14 changes: 13 additions & 1 deletion
14
src/frontend/apps/web/src/features/stock/ui/stock-detail-layout.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,17 @@ | ||
| import StockChartContainer from './stock-chart-container'; | ||
| import StockInfoContainer from './stock-info-container'; | ||
|
|
||
| const StockDetailLayout = () => { | ||
| return <div className="bg-gray-200 w-full h-full">123</div>; | ||
| return ( | ||
| <div className="w-full h-full flex flex-col"> | ||
handje marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| <div className="h-[120px]"> | ||
| <StockInfoContainer /> | ||
| </div> | ||
| <div className="h-full rounded-md overflow-hidden"> | ||
| <StockChartContainer /> | ||
| </div> | ||
| </div> | ||
| ); | ||
| }; | ||
|
|
||
| export default StockDetailLayout; | ||
12 changes: 12 additions & 0 deletions
12
src/frontend/apps/web/src/features/stock/ui/stock-info-container.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
| import StockInfo from './stock-info'; | ||
| import StockLogo from './stock-logo'; | ||
|
|
||
| const StockInfoContainer = () => { | ||
| return ( | ||
| <div className="h-full flex flex-row justify-start items-center gap-3"> | ||
handje marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| <StockLogo /> | ||
| <StockInfo /> | ||
| </div> | ||
| ); | ||
| }; | ||
| export default StockInfoContainer; | ||
17 changes: 17 additions & 0 deletions
17
src/frontend/apps/web/src/features/stock/ui/stock-info.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| const StockInfo = () => { | ||
| return ( | ||
| <div className="flex flex-col gap-2"> | ||
| <div> | ||
| <span className="font-bold mr-1">테슬라</span> | ||
| <span>000000</span> | ||
| </div> | ||
| <div> | ||
| <span className="font-bold mr-2">579,913</span> | ||
| <span className="text-xs"> | ||
| 어제보다 <span className="text-red-700">+6.72(0.2%)</span> | ||
| </span> | ||
| </div> | ||
| </div> | ||
| ); | ||
| }; | ||
| export default StockInfo; |
16 changes: 16 additions & 0 deletions
16
src/frontend/apps/web/src/features/stock/ui/stock-logo.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,16 @@ | ||
| import { Avatar, AvatarFallback, AvatarImage } from '@workspace/ui/components'; | ||
|
|
||
| const StockLogo = () => { | ||
| return ( | ||
| <> | ||
| <Avatar | ||
| variant="square" | ||
| className="w-[60px] h-[60px]" | ||
| > | ||
| <AvatarImage src="https://thumb.tossinvest.com/image/resized/48x0/https%3A%2F%2Fstatic.toss.im%2Fpng-icons%2Fsecurities%2Ficn-sec-fill-NAS006XY7-E0.png" /> | ||
| <AvatarFallback>Logo</AvatarFallback> | ||
| </Avatar> | ||
| </> | ||
| ); | ||
| }; | ||
| export default StockLogo; |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.