Open
Conversation
setunapo
force-pushed
the
fair_develop
branch
7 times, most recently
from
65059e6 to
3bee802
Compare
`fillTransactions` will call `commitTransactions` twice, if the delay
timer is expired during the first call, it will make the delay timer
never be triggered in the second commitTransactions call.
Pseudo code:
x := time.NewTimer(time.Second)
<-x.C
fmt.Println("read delay 1")
<-x.C
fmt.Println("read delay 2") // will never hit
setunapo
force-pushed
the
fair_develop
branch
from
3bee802 to
71eab4d
Compare
** try fillTransactions several times for the best ** drop current mining block on new block imported ** commitTransactions return with a reason ** code refactor, use error code
setunapo
force-pushed
the
fair_develop
branch
from
71eab4d to
a6938d7
Compare
setunapo
force-pushed
the
fair_develop
branch
from
a6938d7 to
2d0c581
Compare
setunapo
force-pushed
the
fair_develop
branch
from
2d0c581 to
4c8fc5a
Compare
setunapo
pushed a commit
that referenced
this pull request
Mar 27, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
add a description of your changes here...
Rationale
tell us why we need these changes...
Example
add an example CLI or API response...
Changes
Notable changes: