Conversation
royopa
commented
Sep 8, 2026
royopa
commented
- Update .csproj files (Console, Library, Test) to net10.0
- Drop the net48 multi-target from the Test project
- Remove dependency on the out-of-support .NET 5 reference packs
- Allow the tool to run on the installed .NET 10 runtime without the .NET 6 runtime
- Update .csproj files (Console, Library, Test) to net10.0 - Drop the net48 multi-target from the Test project - Remove dependency on the out-of-support .NET 5 reference packs - Allow the tool to run on the installed .NET 10 runtime without the .NET 6 runtime
There was a problem hiding this comment.
🟡 Changes recommended
The Console and Library projects currently list net10.0 twice in TargetFrameworks, which will redundantly build/pack the same TFM and can create duplicate artifacts.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Migrates the SchemaZen projects’ target frameworks to .NET 10 so the tool can run on an installed .NET 10 runtime and removes legacy multi-targeting where no longer needed.
Changes:
- Update Test project target framework to
net10.0. - Update Console and Library projects to target .NET 10 (while retaining
net48for the library). - Remove older target frameworks (
net5.0/net6.0) from the multi-target lists.
File summaries
| File | Description |
|---|---|
| Test/Test.csproj | Updates test target framework to net10.0. |
| Library/Library.csproj | Updates target frameworks toward .NET 10 while keeping net48. |
| Console/Console.csproj | Updates tool project target frameworks toward .NET 10. |
Review details
- Files reviewed: 3/3 changed files
- Comments generated: 2
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| <LangVersion>10.0</LangVersion> | ||
| <OutputType>Exe</OutputType> | ||
| <TargetFrameworks>net5.0;net6.0</TargetFrameworks> | ||
| <TargetFrameworks>net10.0;net10.0</TargetFrameworks> |
| <PropertyGroup> | ||
| <LangVersion>10.0</LangVersion> | ||
| <TargetFrameworks>net5.0;net6.0;net48</TargetFrameworks> | ||
| <TargetFrameworks>net10.0;net10.0;net48</TargetFrameworks> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.