Skip to content

Conversation

@Aerilym
Copy link
Collaborator

@Aerilym Aerilym commented Oct 29, 2025

No description provided.

Copilot AI review requested due to automatic review settings October 29, 2025 02:29
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for displaying expiring and expired Pro subscription modals to prompt users for renewal or updates. The implementation introduces two new variants for one-time Pro subscriptions that are expiring soon or have already expired, with appropriate UI states including grayscale styling for expired subscriptions.

  • Adds ONE_TIME_EXPIRE_SOON and ONE_TIME_EXPIRED variants to the SessionProInfoModal
  • Implements conditional UI rendering based on Pro expiration status with appropriate calls-to-action
  • Introduces a hideBackButton option for the ProNonOriginatingPage to prevent navigation away from renewal flows

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

File Description
ts/state/ducks/modalDialog.tsx Adds hideBackButton property to WithUserSettingsPage type for controlling back button visibility
ts/components/dialog/user-settings/pages/user-pro/ProNonOriginatingPage.tsx Implements conditional rendering of back button based on the new hideBackButton prop
ts/components/dialog/debug/playgrounds/ProPlaygroundPage.tsx Adds test buttons for the new expiring/expired Pro variants in the playground
ts/components/dialog/SessionProInfoModal.tsx Implements the main logic for expiring/expired Pro modals including grayscale styling, updated descriptions, CTAs, and feature lists

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@Bilb Bilb merged commit 3559633 into feat/pro-settings Oct 29, 2025
@Bilb Bilb deleted the feat/pro-renew-modals branch October 29, 2025 23:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants