feat: create pro backend wrapper for getting pro proofs #41
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds a new backend wrapper function for generating pro proof request bodies. The implementation handles private key validation, signature generation, and JSON serialization for pro proof requests.
Key Changes:
- Added
proProofRequestBodystatic method to create signed pro proof requests - Introduced
toCppBufferViewutility for efficient buffer handling - Added pro_backend.hpp header inclusion for pro proof request functionality
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| include/utilities.hpp | Declares new toCppBufferView utility function for buffer view conversion |
| include/pro/pro.hpp | Implements proProofRequestBody method for generating signed pro proof request bodies with validation and signature creation |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Bilb
requested changes
Oct 27, 2025
Bilb
reviewed
Oct 29, 2025
Bilb
requested changes
Oct 29, 2025
Bilb
approved these changes
Oct 29, 2025
|
merging even if libsession-util is not up to date. We will fix it soon |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.