Skip to content

Change color tests to check the serialized output #313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 14, 2022

Conversation

tiaanl
Copy link
Collaborator

@tiaanl tiaanl commented Dec 7, 2022

No description provided.

@tiaanl
Copy link
Collaborator Author

tiaanl commented Dec 9, 2022

@emilio it seems like the optimization you were checking for in actions/toolkit#310 is not present on nightly any more. Should we handle this in a different way?

@emilio
Copy link
Member

emilio commented Dec 9, 2022

@emilio it seems like the optimization you were checking for in actions/toolkit#310 is not present on nightly any more. Should we handle this in a different way?

Possibly, see rust-lang/rust#105371

@emilio
Copy link
Member

emilio commented Dec 9, 2022

Maybe we should make ci not block on nightly.

@tiaanl
Copy link
Collaborator Author

tiaanl commented Dec 12, 2022

@emilio It looks like there is no feature that allows marking specific jobs as "allowed to fail". See: actions/runner#2347

Given what was discussed in the rust-lang thread and not beind able to rely on Cow having a specified size, does it make sense to test for the size of this struct?

Also, this is new to me, what are the benefit of having new code compile on beta/nightly and even stable if the msrv is set to a specific version?

@emilio
Copy link
Member

emilio commented Dec 12, 2022

@tiaanl ok, bumped the msrv and fixed CI again in #316, can you remove the last couple commits?

@bors-servo
Copy link
Contributor

☔ The latest upstream changes (presumably actions/toolkit#316) made this pull request unmergeable. Please resolve the merge conflicts.

@tiaanl tiaanl force-pushed the tests-only branch 3 times, most recently from b67a7ad to 0666a74 Compare December 14, 2022 15:37
@emilio
Copy link
Member

emilio commented Dec 14, 2022

@bors-servo r+

@bors-servo
Copy link
Contributor

📌 Commit 0666a74 has been approved by emilio

@bors-servo
Copy link
Contributor

⌛ Testing commit 0666a74 with merge 722b30d...

@bors-servo
Copy link
Contributor

☀️ Test successful - checks-github
Approved by: emilio
Pushing 722b30d to master...

@bors-servo bors-servo merged commit 722b30d into servo:master Dec 14, 2022
@tiaanl tiaanl deleted the tests-only branch December 14, 2022 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants