-
Notifications
You must be signed in to change notification settings - Fork 135
Change color tests to check the serialized output #313
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@emilio it seems like the optimization you were checking for in actions/toolkit#310 is not present on nightly any more. Should we handle this in a different way? |
Possibly, see rust-lang/rust#105371 |
Maybe we should make ci not block on nightly. |
@emilio It looks like there is no feature that allows marking specific jobs as "allowed to fail". See: actions/runner#2347 Given what was discussed in the rust-lang thread and not beind able to rely on Also, this is new to me, what are the benefit of having new code compile on beta/nightly and even stable if the msrv is set to a specific version? |
☔ The latest upstream changes (presumably actions/toolkit#316) made this pull request unmergeable. Please resolve the merge conflicts. |
b67a7ad
to
0666a74
Compare
@bors-servo r+ |
📌 Commit 0666a74 has been approved by |
☀️ Test successful - checks-github |
No description provided.