-
Notifications
You must be signed in to change notification settings - Fork 233
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for declarative shadow DOM #578
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: batu_hoang <[email protected]>
0f7252d
to
da7d3f4
Compare
@longvatrong111 Do you mind changing the name of the commit to "Add support for declarative shadow DOM" as I think ti's a bit confusing to use the word "Update" to describe this change? Thank you! |
@mrobinson sure, I updated. |
ace18d0
to
256fc74
Compare
5 tasks
Signed-off-by: batu_hoang <[email protected]>
256fc74
to
e94e8be
Compare
simonwuelker
requested changes
Mar 6, 2025
simonwuelker
reviewed
Mar 7, 2025
Signed-off-by: batu_hoang <[email protected]>
simonwuelker
approved these changes
Mar 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Servo PR: servo/servo#34964
cc: @xiaochengh, @simonwuelker