test: Updating and implementing tests for 'date' header to supporte l…

…azy initialization
serverpod · Dec 17, 2024 · f83c6c1 · f83c6c1
1 parent 7708d0c
commit f83c6c1
Show file tree

Hide file tree

Showing 2 changed files with 26 additions and 0 deletions.
diff --git a/test/headers/basic/date_header_test.dart b/test/headers/basic/date_header_test.dart
@@ -39,6 +39,8 @@ void main() {
           () async => await getServerRequestHeaders(
             server: server,
             headers: {'date': ''},
+            // trigger lazy initialization
+            onHeadersParsed: (headers) => headers?.date,
           ),
           throwsA(
             isA<BadRequestException>().having(
@@ -60,6 +62,8 @@ void main() {
           () async => await getServerRequestHeaders(
             server: server,
             headers: {'date': 'invalid-date-format'},
+            // trigger lazy initialization
+            onHeadersParsed: (headers) => headers?.date,
           ),
           throwsA(
             isA<BadRequestException>().having(
@@ -72,6 +76,20 @@ void main() {
       },
     );
 
+    test(
+      'when a Date header with an invalid date format is passed '
+      'then the server does not respond with a bad request if the headers '
+      'is not actually used',
+      () async {
+        Headers headers = await getServerRequestHeaders(
+          server: server,
+          headers: {'date': 'invalid-date-format'},
+        );
+
+        expect(headers, isNotNull);
+      },
+    );
+
     test(
       'when a valid Date header is passed then it should parse the date correctly',
       () async {
@@ -155,6 +173,7 @@ void main() {
           Headers headers = await getServerRequestHeaders(
             server: server,
             headers: {'date': ''},
+            onHeadersParsed: (headers) => headers?.date,
           );
 
           expect(
@@ -172,6 +191,7 @@ void main() {
           Headers headers = await getServerRequestHeaders(
             server: server,
             headers: {'date': 'invalid-date-format'},
+            onHeadersParsed: (headers) => headers?.date,
           );
 
           expect(headers.date, isNull);
@@ -184,6 +204,7 @@ void main() {
           Headers headers = await getServerRequestHeaders(
             server: server,
             headers: {'date': 'invalid-date-format'},
+            onHeadersParsed: (headers) => headers?.date,
           );
 
           expect(

diff --git a/test/headers/headers_test_utils.dart b/test/headers/headers_test_utils.dart
@@ -17,12 +17,17 @@ class BadRequestException implements Exception {
 Future<Headers> getServerRequestHeaders({
   required RelicServer server,
   required Map<String, String> headers,
+  // Since we implement lazy initialization, we need to pass a function
+  // in order to access the headers that we are interested in and trigger
+  // the lazy initialization.
+  void Function(Headers?)? onHeadersParsed,
 }) async {
   Headers? parsedHeaders;
 
   server.mountAndStart(
     (Request request) {
       parsedHeaders = request.headers;
+      onHeadersParsed?.call(parsedHeaders);
       return Response.ok();
     },
   );