Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rebuild of pixorama for serverpod 1.2.3 #7

Open
wants to merge 17 commits into
base: main
Choose a base branch
from
Open

Rebuild of pixorama for serverpod 1.2.3 #7

wants to merge 17 commits into from

Conversation

saammz
Copy link

@saammz saammz commented Feb 20, 2024 •
edited
Loading

Changes:

  • Updated server-side to accommodate the latest version of Serverpod

PRE-LAUCH CHECKLIST

  • I read the Contribute page and followed the process outlined there for submitting PRs.
  • This update contains only one single feature or bug fix and nothing else. (If you are submitting multiple fixes, please make multiple PRs.)
  • I read and followed the Dart Style Guide and formatted the code with dart format.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///), and made sure that the documentation follows the same style as other Serverpod documentation. I checked spelling and grammar.
  • I added new tests to check the change I am making.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the discussion board.

vlidholt
vlidholt requested changes Feb 20, 2024
View reviewed changes
Copy link
Contributor

@vlidholt vlidholt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great start on updating this project and I assume the app works locally! :)

It looks like you have just added the files from the old pixorama on top of a new project. There are files that should be removed (like the example files from the default project). The project also demonstrates how to use the Relic webserver to host a Flutter web app, this is no longer working as those files have been overwritten by the new project.

Please see the comments for some examples of the above, but there may be more places in the code where this is also true. So please go over all the files one more time.

Before you send the PR, review all the changes you have made to make sure that they are intentionally made.

pixorama_flutter/.gitignore Outdated Show resolved Hide resolved
pixorama_flutter/lib/main.dart Outdated Show resolved Hide resolved
pixorama_flutter/lib/src/connection_display.dart Outdated Show resolved Hide resolved
pixorama_client/lib/src/protocol/example.dart Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file should not be here.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Resolved

pixorama_server/.gitignore Show resolved Hide resolved
pixorama_server/docker-compose.yaml Outdated Show resolved Hide resolved
pixorama_server/lib/src/models/example.spy.yaml Outdated Show resolved Hide resolved
pixorama_server/lib/src/web/widgets/default_page_widget.dart Outdated Show resolved Hide resolved
pixorama_server/lib/src/endpoints/example_endpoint.dart Outdated Show resolved Hide resolved
pixorama_server/lib/src/generated/protocol.yaml Outdated Show resolved Hide resolved
@saammz saammz requested a review from vlidholt February 23, 2024 09:39
vlidholt
vlidholt requested changes Feb 26, 2024
View reviewed changes
Copy link
Contributor

@vlidholt vlidholt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work on this! There are still a couple of things that need to be fixed.

README.md Outdated Show resolved Hide resolved
pixorama_client/lib/src/.DS_Store Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
pixorama_server/lib/src/web/widgets/index_page_widget.dart Outdated Show resolved Hide resolved
pixorama_server/web/static/css/style.css Outdated Show resolved Hide resolved
pixorama_server/web/static/images/background.svg Outdated Show resolved Hide resolved
pixorama_server/web/static/style.css Outdated Show resolved Hide resolved
pixorama_server/web/templates/default.html Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should not have been added.

@saammz saammz requested a review from vlidholt March 11, 2024 11:22
vlidholt
vlidholt requested changes Mar 15, 2024
View reviewed changes
README.md Outdated

```bash
flutter run
flutter run -d Chrome
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

flutter run -d chrome

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@saammz saammz requested a review from vlidholt March 15, 2024 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vlidholt vlidholt Awaiting requested review from vlidholt

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@saammz @vlidholt @developersFreelance