Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add input prompt component #14

Merged
merged 3 commits into from
Jan 17, 2025
Merged

feat: add input prompt component #14

merged 3 commits into from
Jan 17, 2025

Conversation

hampuslavin
Copy link
Contributor

@hampuslavin hampuslavin commented Jan 16, 2025 •
edited
Loading

Description

  • Adds trivial input prompt component:
image
  • 💡 Note: I considered adding a generic T value alternatively an explicit function for numbers numberInput. However, this is such a trivial thing to build on top for the specific use case so I kept it simple.

@hampuslavin hampuslavin requested a review from SandPod January 17, 2025 12:38
@hampuslavin hampuslavin marked this pull request as ready for review January 17, 2025 12:38
SandPod
SandPod reviewed Jan 17, 2025
View reviewed changes
Copy link
Contributor

@SandPod SandPod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two minor questions.

lib/src/prompts/input.dart Show resolved Hide resolved
test/prompts/input_test.dart Outdated Show resolved Hide resolved
@hampuslavin hampuslavin requested a review from SandPod January 17, 2025 13:00
SandPod
SandPod approved these changes Jan 17, 2025
View reviewed changes
Copy link
Contributor

@SandPod SandPod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@hampuslavin hampuslavin merged commit 297d4fd into main Jan 17, 2025
3 checks passed
@hampuslavin hampuslavin deleted the hl_add_input branch January 17, 2025 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SandPod SandPod SandPod approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hampuslavin @SandPod