feat: add select and multiselect prompt components #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hampuslavin
force-pushed
the
hl_add_multiselect
branch
from
74e4b1d to
dc74fb2
Compare
hampuslavin
force-pushed
the
hl_add_multiselect
branch
from
dc74fb2 to
5a67181
Compare
SandPod
reviewed
Jan 16, 2025
There was a problem hiding this comment.
Nice work!
Couple of questions around things I don't have knowledge about and a couple of suggestions. It feels like the implementation can be made a bit simpler if we introduce some class that contains the state. (Kind of like a game board with a fixed set of allowed operations separated from parsing input)
hampuslavin
force-pushed
the
hl_add_multiselect
branch
from
64f86be to
3a140c1
Compare
hampuslavin
force-pushed
the
hl_add_multiselect
branch
from
5e6584b to
a723184
Compare
hampuslavin
force-pushed
the
hl_add_multiselect
branch
from
6b6b5ea to
5c41ce3
Compare
SandPod
reviewed
Jan 17, 2025
hampuslavin
force-pushed
the
hl_add_multiselect
branch
from
bb8c064 to
49ea5c6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
selectandmultiselectprompt componentsselect
multiselect