-
Notifications
You must be signed in to change notification settings - Fork 14
fix dependencies, tests, and clean code #35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Changes from 1 commit
f5766f3
d679471
cd5d28c
deb7d98
d7df61f
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| 10.15 |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -16,20 +16,20 @@ | |
| "author": "Serverless, Inc.", | ||
| "license": "Apache-2.0", | ||
| "devDependencies": { | ||
| "@types/aws-lambda": "^8.10.115", | ||
| "@types/chai": "^4.3.5", | ||
| "@types/mocha": "^5.2.7", | ||
| "@types/node": "^11.15.54", | ||
| "aws-lambda": "^0.1.2", | ||
| "chai": "^4.3.7", | ||
| "mocha": "^6.2.3", | ||
| "ts-mocha": "^6.0.0", | ||
| "ts-node": "^8.10.2", | ||
| "tslint": "^5.20.1", | ||
| "typescript": "^3.9.10" | ||
| "@types/aws-lambda": "8.10.24", | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Why dependencies are downgraded? Are those packages not respecting semver?
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
If we think we need to have the newer version then we should make a v2 that uses latest packages and node
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I simply followed semever and updated packages in version range that should not introduce breaking changes. Majority of packages on npm follow semver, so it was pretty natural move, that normally works. It's kind of surprising it isn't here. Therefore if you're sure that some of the bumped packages do not follow semver please fix them to a specific version, but rest should be safe with
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @medikoo I have packages updated where it will build with the newest. |
||
| "@types/chai": "4.1.7", | ||
| "@types/lodash": "4.14.123", | ||
| "@types/mocha": "5.2.6", | ||
| "@types/node": "11.13.4", | ||
| "aws-lambda": "0.1.2", | ||
| "chai": "4.3.7", | ||
| "mocha": "6.2.3", | ||
| "ts-mocha": "6.0.0", | ||
| "ts-node": "8.1.0", | ||
| "tslint": "5.15.0", | ||
| "typescript": "3.4.5" | ||
| }, | ||
| "dependencies": { | ||
| "@types/lodash": "^4.14.194", | ||
| "lodash": "^4.17.21" | ||
| "lodash": "4.17.11" | ||
| } | ||
| } | ||
Uh oh!
There was an error while loading. Please reload this page.