Create npmpublish.yml GitHub Action #581
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
@HyperBrain Are you comfortable creating an npm token and adding it to the "secrets" in this repository's settings? This way, we can automatically publish to npm when we create a GitHub release. The secrets are not visible by anyone, not even the person who created it. |
|
Thank you @HyperBrain and @miguel-a-calles-mba for keeping traction on this repo, it's very handy and still quite active! I'm eagerly awaiting PR #570 as I'm sure there are several others as well. |
Member
Author
|
@revgum np. I'm looking forward to other PRs too. =) |
Member
|
@miguel Calles <[email protected]> I will create a npm token and
let you know.
…On Wed, Apr 22, 2020 at 3:39 PM Miguel A. Calles MBA < ***@***.***> wrote:
@revgum <https://github.com/revgum> np.
I'm looking forward to other PRs too. =)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#581 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABKEZXWQCVYO7GRBLLT3VL3RN3XSNANCNFSM4MMWXCSQ>
.
|
Member
Author
|
Thanks @HyperBrain ! |
Member
Author
|
@HyperBrain @jamesmbourne @rdsedmundo Reference the internal team discussion about the updated npm token secret. |
jamesmbourne
approved these changes
Apr 25, 2020
miguel-a-calles-mba
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What did you implement:
Closes #XXXXX
Adding a GitHub Action to automatically publish to npm.
How did you implement it:
Added a GitHub Action YAML workflow.
How can we verify it:
Define the
NPM_TOKENsecret in the settings. Update the package version, create a release, and see the action work. https://github.com/serverless-heaven/serverless-webpack/actionsTodos:
Is this ready for review?: YES
Is it a breaking change?: NO