Skip to content

Conversation

sirhcel
Copy link
Contributor

@sirhcel sirhcel commented Oct 7, 2025

Generating the latest documentation on docs.rs failed with https://docs.rs/crate/serialport/4.8.0/builds/2566488. It looks like rust-lang/rust#138907 landed there and we have to update our configuration for it.

Generating docs for release 4.8.0 failed at docs.rs
(https://docs.rs/crate/serialport/4.8.0/builds/2566488) and it turns out
that we don't check for issues from generating docs in CI.
It looks like the issue with building the latest docs originated from
rust-lang/rust#138907 getting into effect at
docs.rs.
This is a quick follow-up to 4.8.0 git have up-to-date docs on docs.rs
again.
@sirhcel sirhcel force-pushed the fix-failed-docs-4.8.0 branch from c0e05d8 to 1bf8156 Compare October 7, 2025 10:01
@sirhcel sirhcel changed the title Fix gerenating documentation at docs.rs Fix gerenating documentation at docs.rs and release 4.8.1 Oct 7, 2025
@sirhcel sirhcel requested a review from eldruin October 7, 2025 10:01
@sirhcel
Copy link
Contributor Author

sirhcel commented Oct 7, 2025

Links for the latest release fail as it is not tagged yet.

Copy link
Contributor

@eldruin eldruin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for fixing this!

@eldruin eldruin merged commit bb1f8f3 into serialport:main Oct 7, 2025
42 of 43 checks passed
@sirhcel
Copy link
Contributor Author

sirhcel commented Oct 7, 2025

Thank you for the quick review @eldruin!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants