Skip to content

Feature: Allow to skip seq access for internally and adjacently tagged enums #2933

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Feature: Allow to skip seq access for internally and adjacently tagged enums #2933

wants to merge 3 commits into from

Conversation

Dzordzu
Copy link

@Dzordzu Dzordzu commented May 26, 2025 •
edited
Loading

About

Implementation of the #2932
Refers to #2917

Changes

  • Allowed to add seq=true/false to the serde internally and adjacently tagged enums
  • Fixed wrong lint

This was referenced May 26, 2025
Draft
Draft
Mingun
Mingun reviewed May 26, 2025
View reviewed changes
Copy link
Contributor

@Mingun Mingun left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new attribute probably better name seq_form to emphasis that it influences to the possible serialized forms of the type. Also, the same attribute could be also supported on structs.

@Dzordzu
Naming, compile-time flag check, updated tests
2addbae 
* `seq` to `seq_form` rename
* now flag is only evaluated at the compile time.
* updated tests to match new naming
@Dzordzu Dzordzu force-pushed the feature/allow_do_skip_seq_access branch from 0944b03 to 2addbae Compare May 27, 2025 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mingun Mingun Mingun left review comments

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Dzordzu @Mingun