Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(serde): rewrite with a simpler model #8

Merged
merged 16 commits into from
Feb 12, 2024
Merged

feat(serde): rewrite with a simpler model #8

merged 16 commits into from
Feb 12, 2024

Conversation

leostera
Copy link
Member

@leostera leostera commented Feb 4, 2024

This PR rewrites Serde to use a much simpler model that:

  • has no intermediate representation of data
  • supports direct data-to/from-format transformations
  • is actually usable without a ppx
  • fits in a single module

On top of this, we've rewritten the JSON format module and managed to get:

  • unit variants
  • newtype variants
  • tuple variants
  • record variants
  • records
  • nested records
  • options
  • lists
  • arrays

and have roundtrip tests for all of them.

@leostera leostera marked this pull request as ready for review February 12, 2024 07:18
@leostera leostera merged commit 6819052 into main Feb 12, 2024
0 of 4 checks passed
@leostera leostera deleted the rewrite branch February 12, 2024 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant