775 use tiered cache in place of caffeine cache #783
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: munishchouhan <[email protected]>
…e-in-place-of-caffeine-cache
Signed-off-by: munishchouhan <[email protected]>
Signed-off-by: munishchouhan <[email protected]>
Signed-off-by: munishchouhan <[email protected]>
Signed-off-by: munishchouhan <[email protected]>
Signed-off-by: munishchouhan <[email protected]>
Signed-off-by: munishchouhan <[email protected]>
Signed-off-by: munishchouhan <[email protected]>
3 tasks
Signed-off-by: munishchouhan <[email protected]>
Signed-off-by: munishchouhan <[email protected]>
|
Tested locally with Redis:
|
Signed-off-by: munishchouhan <[email protected]>
This reverts commit 33049bf.
|
Tested Dev:
|
Signed-off-by: munishchouhan <[email protected]>
Signed-off-by: munishchouhan <[email protected]>
Signed-off-by: munishchouhan <[email protected]>
pditommaso
reviewed
Jan 27, 2025
| @@ -293,4 +318,8 @@ abstract class AbstractTieredCache<V extends MoshiExchange> implements TieredCac | |||
| l1.invalidateAll() | |||
| } | |||
|
|
|||
| void invalidate(K key) { | |||
| l1.invalidate(key.stableHash()) | |||
| } | |||
There was a problem hiding this comment.
This is a problem because it removes the value only from the caffeine cache but it remains in redis, and even worse in the in-memory cache in other nodes that may have loaded that value
There was a problem hiding this comment.
for now, i have removed registryauthcache till the time we done find solution to invalidate it from all app instances
Signed-off-by: Paolo Di Tommaso <[email protected]>
This reverts commit c7e8536.
Signed-off-by: munishchouhan <[email protected]>
Signed-off-by: munishchouhan <[email protected]>
Signed-off-by: munishchouhan <[email protected]>
Signed-off-by: munishchouhan <[email protected]>
Signed-off-by: munishchouhan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the following:
RegistryAuthCache