Add label support to workflow-launch node #34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds ability to specify comma-separated label names when launching workflows. Labels are automatically created if they don't exist in the workspace, following the same approach as tower-cli. The node resolves label names to IDs and includes them in the launch request. - Add labels field to workflow-launch node UI - Implement label name resolution and auto-creation - Support labels for both regular and resume workflows - Use workspaceId as query parameter per tower-cli implementation - Convert label IDs to strings as required by API - Add comprehensive error handling for label operations 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Sonnet 4.5 <[email protected]>
🐳 Docker PR Build
|
ewels
reviewed
Dec 22, 2025
Member
ewels
left a comment
ewels
left a comment
There was a problem hiding this comment.
Great stuff!
Had a read through of the code, generally looks great - just a few minor comments.
Address PR #34 review feedback by refactoring label resolution logic: - Extract duplicate code into resolveLabelIds helper function - Add case-insensitive label handling (normalize to lowercase) - Change from warnings to errors for fail-fast behavior on label failures - Fix error handling to pass msg parameter for proper Node-RED context - Use search parameter in API calls to avoid pagination issues - Remove redundant header specifications (handled by apiCall utility) This improves code maintainability, scalability, and error handling while ensuring labels with different casing are treated as the same label. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Sonnet 4.5 <[email protected]>
Consolidate label resolution to single location after both regular launch and resume workflow paths have set up body.launch. Both code paths ultimately populate body.launch, so labels can be applied once instead of duplicating the logic in two places. Fix permission requirements in error messages and documentation: - Change from incorrect "label:write" permission to "Maintain role or higher" - Workspace labels (used by this node) can be created by Maintain role - Resource labels (for cost tracking) require Admin/Owner roles This reduces code duplication and provides accurate guidance to users about required token permissions. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Sonnet 4.5 <[email protected]>
Adds 8 new test cases for workflow-launch node labels feature: - Label resolution and ID mapping for existing labels - Automatic label creation when labels don't exist - Permission error handling (403) with helpful error messages - Case-insensitive label matching - Whitespace trimming in comma-separated labels - Empty label handling - Integration with resume workflow functionality - Dynamic labels from message properties (typedInput) Also adds helper factories (createLabelsResponse, createLabelResponse) to test/helper.js for mocking Seqera API label endpoints. All 173 tests passing. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Sonnet 4.5 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds ability to specify comma-separated label names when launching workflows. Labels are automatically created if they don't exist in the workspace, following the same approach as tower-cli. The node resolves label names to IDs and includes them in the launch request.
🤖 Generated with Claude Code