feat: warn when CUR cost data is incomplete#149
Merged
FloWuenne merged 2 commits intoremove-seqera-predicted-costfrom May 1, 2026
Merged
feat: warn when CUR cost data is incomplete#149FloWuenne merged 2 commits intoremove-seqera-predicted-costfrom
FloWuenne merged 2 commits intoremove-seqera-predicted-costfrom
Conversation
Co-authored-by: Florian Wuennemann <flowuenne@gmail.com>
Co-authored-by: Florian Wuennemann <flowuenne@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR checklist
CITATIONS.md,README.md, and agent/context guidance in the same PR.nextflow run . -profile test,docker --outdir <OUTDIR>).nextflow run . -profile debug,test,docker --outdir <OUTDIR>).CHANGELOG.mdis updated.README.mdis updated (including new tool citations and authors/contributors).Description
Add explicit CUR coverage reporting so the benchmark report warns when a supplied CUR does not cover all included tasks. Instead of silently presenting unmatched tasks as zero-cost totals, the report now summarizes missing-cost runs and processes in a short warning card.
What changed
cost_coveragemetadata toreport_data.jsonWalkthrough
benchmark_report_warning_walkthrough.mp4
Incomplete CUR warning in compiled benchmark report
Testing
python3 -m pytest -v modules/local/aggregate_benchmark_report_data/tests/test_aggregate.py modules/local/render_benchmark_report/tests/test_render.pypython3 -m pytest -v modules/local/aggregate_benchmark_report_data/tests/test_aggregate.py modules/local/normalize_benchmark_jsonl/tests/test_normalize.py modules/local/render_benchmark_report/tests/test_render.py bin/test_benchmark_report_fetch.pypython3 bin/benchmark_report.py normalize-jsonl --data-dir /tmp/cur-warning-demo/data --costs /tmp/cur-warning-demo/partial_cur.parquet --output-dir /tmp/cur-warning-demo/jsonl_bundlepython3 bin/benchmark_report.py aggregate-report-data --jsonl-dir /tmp/cur-warning-demo/jsonl_bundle --output /tmp/cur-warning-demo/report_data.jsonpython3 bin/benchmark_report.py render-html --data /tmp/cur-warning-demo/report_data.json --brand assets/brand.yml --output /tmp/cur-warning-demo/report.html/root/.local/bin/pre-commit run --all-filesNotes
Container-backed
nf-test/ full Nextflow docker verification remains blocked in this VM because Docker launches hit the known cgroup/socket environment issue, but the Python stage tests and local normalize/aggregate/render compile flow all passed.To show artifacts inline, enable in settings.