feat(lib-cloudinfo): add value-based equals/hashCode to ProductsQuery#66
Merged
Merged
Conversation
ProductsQuery is a small filter parameter object passed to the Cloudinfo products endpoint. Without value-based equality, instances built from the same flags compared as unequal, which broke caching and made them unsafe as map keys. This adds equals, hashCode, and toString based on the existing sched and nvme flags. A reflection-based Spock test guards future fields: any new declared instance field that is not wired into hashCode (or equals) will fail the suite, preventing silent caching bugs in consumers. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
cristianrcv
approved these changes
May 7, 2026
jonmarti
approved these changes
May 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
equals,hashCode, andtoStringtoProductsQuerybased on the existingsched/nvmeflags so instances built from the same inputs compare equal and can be used safely as map keys.ProductsQueryTestwith a reflection-based guard: any future instance field not wired intohashCode/equalsfails the suite, preventing silent caching bugs in consumers.Test plan
./gradlew :lib-cloudinfo:test --tests "*ProductsQueryTest*"passes locally🤖 Generated with Claude Code