chore: Review and improve the editorial workflow#1391
Open
justinegeffen wants to merge 8 commits intomasterfrom
Open
chore: Review and improve the editorial workflow#1391justinegeffen wants to merge 8 commits intomasterfrom
justinegeffen wants to merge 8 commits intomasterfrom
Conversation
✅ Deploy Preview for seqera-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
justinegeffen
added
1. Editor review
Custom subagents declared in .claude/agents/ don't get tool access at runtime in Claude Code 2.1.123 — they confabulate findings without ever reading the file. Reported upstream as anthropics/claude-code#56398. Routes Step 3 of the editorial-review skill through general-purpose with the agent's body inlined as the system prompt, and adds two backstops: - READ-PROOF requirement: agents must paste 3 verbatim line excerpts from their Read output before any findings. - Verification gate (new Step 5): orchestrator drops any block whose ORIGINAL doesn't match the file at LINE, plus all blocks from agents that fail the READ-PROOF check. Co-Authored-By: Claude Opus 4.7 (1M context) <[email protected]>
The previous collation rule silenced any lower-priority agent's fix when a higher-priority agent flagged anything on the same line, even when the two suggestions targeted different spans (e.g., voice-tone fixing "Users can" while terminology fixed "Platform" elsewhere on the same line). Because GitHub inline suggestions are full-line replacements, the user could only apply one — silently losing the other fix. The orchestrator now attempts a textual merge first: if the agents touched non-overlapping spans, combine both edits into a single SUGGESTION. Only fall back to the priority rule when the spans overlap and a real conflict exists. Co-Authored-By: Claude Opus 4.7 (1M context) <[email protected]>
Local /editorial-review previously dumped contract blocks to chat as plain text — the user had to navigate to each line and apply by hand. That's not "inline" in any meaningful sense. Adds a new step at the end of local mode: after printing the verified blocks, ask "Apply these N fixes via Edit? (yes / no / pick)". On yes, iterate the blocks calling Edit for each — Claude Code's tool-permission flow shows a per-edit diff to approve or reject. "pick" lets the user select a subset by block number. This delivers the inline-suggestion-style approve/reject UX locally that CI gets via post-inline-suggestions.sh. Co-Authored-By: Claude Opus 4.7 (1M context) <[email protected]>
…rmission mode The previous local-apply flow relied on Claude Code's per-Edit tool-permission prompt to gate each fix. That doesn't work when Claude Code is in acceptEdits mode: Edit calls auto-apply with no prompt, silently bypassing the approve/reject step the user expects. Move the gate into chat instead. For each block: print a compact diff, ask "Apply this fix? (y / n / q)", and only call Edit on y. Works regardless of Claude Code's permission mode. Co-Authored-By: Claude Opus 4.7 (1M context) <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR includes improvements to the existing editorial workflow. The review can be run locally to test before merging. Use /editorial-review in Claude code.