Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX,TEST] Do not check zlib output for alternative implementations #3324

Merged
merged 1 commit into from
Jan 21, 2025
Merged

[FIX,TEST] Do not check zlib output for alternative implementations #3324

merged 1 commit into from
Jan 21, 2025

Conversation

eseiler
Copy link
Member

@eseiler eseiler commented Jan 21, 2025

Resolves #3323

@seqan-actions seqan-actions added lint [INTERNAL] signal for linting and removed lint [INTERNAL] signal for linting labels Jan 21, 2025
eseiler
eseiler commented Jan 21, 2025
View reviewed changes
test/unit/io/stream/ostream_test_template.hpp
buffer[9] = '\x00'; // zero-out the OS byte.
SEQAN3_TEST_GTEST_SKIP_ZLIB_DEFLATE;
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The template is also used for bz2, which we don't want to skip.
zero_out_os_byte (also used for istream template) is currently equivalent to is_zlib_compression.

@seqan-actions
Copy link
Member

Documentation preview available at https://docs.seqan.de/preview/seqan/seqan3/3324

@codecov Codecov
Copy link

codecov bot commented Jan 21, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.11%. Comparing base (787d724) to head (04913ed).
Report is 2 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #3324   +/-   ##
=======================================
  Coverage   98.11%   98.11%           
=======================================
  Files         271      271           
  Lines       11923    11923           
  Branches      104      104           
=======================================
  Hits        11698    11698           
  Misses        225      225

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

SGSSGene
SGSSGene approved these changes Jan 21, 2025
View reviewed changes
Copy link
Contributor

@SGSSGene SGSSGene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very cool! Thx!

@eseiler eseiler merged commit c8e7fdb into seqan:main Jan 21, 2025
40 checks passed
@eseiler eseiler deleted the fix/zlib-ng branch January 21, 2025 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SGSSGene SGSSGene SGSSGene approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

seqan3 -3.4.0 rc2: some tests failed
3 participants
@eseiler @seqan-actions @SGSSGene