fix: add vroom PVC Helm hooks when enable profiling feature

[patsevanton]

This PR addresses an issues 1947 and 1900 where the vroom Deployment was not being created when using asHook: true configuration, despite the PVC being properly annotated with Helm hooks. The problem occurred because the PVC was created with hook annotations, but the corresponding Deployment lacked the necessary hook metadata and the condition to generate it was not met.

Changes Made:

1. Added Helm hook annotations to vroom Deployment and PVC templates (charts/sentry/templates/sentry/vroom/deployment-vroom.yaml, charts/sentry/templates/sentry/vroom/pvc-vroom.yaml):
   • Added meta.helm.sh/release-name and meta.helm.sh/release-namespace annotations.
   • Added helm.sh/hook with value post-install,post-upgrade.
   • Added helm.sh/hook-weight to ensure the PVC weight 25.

Root Cause:

The vroom Deployment template is conditionally included only when:

• feature-complete is in the profiles list
• sentry.features.enableProfiling is true

However, when using asHook: true, the Deployment was not being generated because:

1. The profiling feature was disabled by default (enableProfiling: false).
2. Even when the feature was enabled via values, the Deployment lacked the proper hook annotations to be managed as a Helm hook.

Verification & Testing Instructions:

Important: To verify this fix works, you must test with a configuration where sentry.features.enableProfiling is set to true. This is the key condition for the vroom Deployment to be rendered.

Test Values:

sentry:
  features:
    enableProfiling: true  # <- This must be true for the Deployment to be created.

Before this fix:
The vroom Deployment would not be created, leaving the Helm release in a pending-install state.

kubectl get deployments -n test -l "helm.sh/hook"
# No resources found in test namespace.

helm status sentry -n test
# STATUS: pending-install

After this fix:
With the correct values (notably enableProfiling: true), the vroom Deployment and PVC are now properly created with Helm hook annotations.

kubectl get deployments,pvc -n test -l "helm.sh/hook"
# The vroom Deployment and PVC should now be listed.

The generated manifests will correctly include both the PVC and the Deployment with proper Helm hook annotations, ensuring they are managed as post-install/post-upgrade hooks when asHook: true is configured.

[patsevanton]

check:

k get pod -n test
NAME                                                              READY   STATUS    RESTARTS      AGE
sentry-billing-metrics-consumer-99d4bcd97-5rqvc                   1/1     Running   0             14m
sentry-clickhouse-0                                               1/1     Running   0             33m
sentry-cron-6849c7b85b-wzz6g                                      1/1     Running   1 (32m ago)   33m
sentry-generic-metrics-consumer-568c98554c-zmqz8                  1/1     Running   0             14m
sentry-ingest-consumer-attachments-5c4b5968df-wzm7w               1/1     Running   0             14m
sentry-ingest-consumer-events-cf4c74c79-x7r6z                     1/1     Running   0             14m
sentry-ingest-consumer-transactions-7dd9ddcf67-kckhs              1/1     Running   0             14m
sentry-ingest-monitors-59d96f57d9-jxxm5                           1/1     Running   0             14m
sentry-ingest-occurrences-68c6c68b58-8w6ts                        1/1     Running   0             14m
sentry-ingest-profiles-56574677d6-k5nlp                           1/1     Running   0             14m
sentry-ingest-replay-recordings-879bf44cb-zfvcj                   1/1     Running   0             14m
sentry-issue-occurrence-consumer-76cd5fb55f-gw46m                 1/1     Running   0             14m
sentry-kafka-controller-0                                         1/1     Running   0             33m
sentry-kafka-controller-1                                         1/1     Running   0             33m
sentry-kafka-controller-2                                         1/1     Running   0             33m
sentry-metrics-consumer-7984f8bf59-d2qsl                          1/1     Running   0             14m
sentry-nginx-76b877d65c-dl27v                                     1/1     Running   0             33m
sentry-post-process-forward-errors-694bf4ccf6-44kcd               1/1     Running   0             14m
sentry-post-process-forward-issue-platform-84b9dbb849-hpqbj       1/1     Running   0             14m
sentry-post-process-forward-transactions-5d6d89c749-vq769         1/1     Running   0             14m
sentry-process-segments-6b57c74576-67c6s                          1/1     Running   0             14m
sentry-process-spans-587c5fb99-qh2zt                              1/1     Running   0             14m
sentry-rabbitmq-0                                                 1/1     Running   0             33m
sentry-relay-58b96769f9-bssvb                                     1/1     Running   0             14m
sentry-sentry-postgresql-0                                        1/1     Running   0             33m
sentry-sentry-redis-master-0                                      1/1     Running   0             33m
sentry-sentry-redis-replicas-0                                    1/1     Running   0             33m
sentry-snuba-api-f74b4f588-xrgt6                                  1/1     Running   0             33m
sentry-snuba-consumer-6cb4cb8757-x2k2m                            1/1     Running   0             14m
sentry-snuba-eap-items-consumer-7845d45b9f-2w2mw                  1/1     Running   0             14m
sentry-snuba-generic-metrics-counters-consumer-7dbfd55c49-89b2h   1/1     Running   0             14m
sentry-snuba-generic-metrics-distributions-consumer-748d6c29qn5   1/1     Running   0             14m
sentry-snuba-generic-metrics-gauges-consumer-9654b4b99-p6rqt      1/1     Running   0             14m
sentry-snuba-generic-metrics-sets-consumer-64b9754c7c-8xwsx       1/1     Running   0             14m
sentry-snuba-group-attributes-consumer-84b5c99ffc-xzl2k           1/1     Running   0             14m
sentry-snuba-metrics-consumer-5fcf4484d6-m4dtk                    1/1     Running   0             14m
sentry-snuba-outcomes-billing-consumer-df4495b86-hp9gp            1/1     Running   0             14m
sentry-snuba-outcomes-consumer-77b6db7ff6-rn5j4                   1/1     Running   0             14m
sentry-snuba-profiling-chunks-consumer-c85d9fdb-rxgfr             1/1     Running   0             14m
sentry-snuba-profiling-functions-consumer-677949469-j5px4         1/1     Running   0             14m
sentry-snuba-profiling-profiles-consumer-784c4f96bf-bdvkp         1/1     Running   0             14m
sentry-snuba-replacer-dfb58ccbd-jx6f9                             1/1     Running   0             14m
sentry-snuba-replays-consumer-645b8d5b77-bf8cg                    1/1     Running   0             14m
sentry-snuba-spans-consumer-67f97b997f-6kqbl                      1/1     Running   0             14m
sentry-snuba-subscription-consumer-eap-items-765f858657-2dfzg     1/1     Running   0             14m
sentry-snuba-subscription-consumer-events-dbccb685f-7qn7g         1/1     Running   0             14m
sentry-snuba-subscription-consumer-generic-metrics-counterdxm4s   1/1     Running   0             14m
sentry-snuba-subscription-consumer-generic-metrics-distrib5b9sb   1/1     Running   0             14m
sentry-snuba-subscription-consumer-generic-metrics-gauges-fc6tx   1/1     Running   0             14m
sentry-snuba-subscription-consumer-generic-metrics-sets-6866fdm   1/1     Running   0             14m
sentry-snuba-subscription-consumer-metrics-ddd5cbfb-zhx94         1/1     Running   0             14m
sentry-snuba-subscription-consumer-transactions-94977b985-nwjgj   1/1     Running   0             14m
sentry-snuba-transactions-consumer-654bdd67df-4b9s2               1/1     Running   0             14m
sentry-snuba-uptime-results-consumer-69b947f485-v2j7v             1/1     Running   0             14m
sentry-subscription-consumer-events-7dc6fff857-r75kd              1/1     Running   0             14m
sentry-subscription-consumer-generic-metrics-694c86f494-7htvn     1/1     Running   0             14m
sentry-subscription-consumer-metrics-b7fbdf66b-m2lhk              1/1     Running   0             14m
sentry-subscription-consumer-results-eap-items-ccc75bd95-n7vm2    1/1     Running   0             14m
sentry-subscription-consumer-transactions-57d6666757-rnlsc        1/1     Running   0             14m
sentry-uptime-results-6dc8cbbbc-bwhht                             1/1     Running   0             14m
sentry-vroom-6b88c586c-vrj28                                      1/1     Running   0             14m
sentry-web-f7858f768-mjs5s                                        1/1     Running   0             33m
sentry-worker-5c78f95d4c-gcgpv                                    1/1     Running   1 (32m ago)   33m
sentry-zookeeper-clickhouse-0                                     1/1     Running   0             33m

[patsevanton]

@Mokto Could you review pull request?