Skip to content

feat: enhance worker deployments with additional packages and CA certificates #1944

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 6 commits into
base: develop
Choose a base branch
from
Draft

feat: enhance worker deployments with additional packages and CA certificates #1944

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
9ea1f71
feat: enhance worker deployments with additional packages and CA cert…
patsevanton Nov 19, 2025
7eb3fa2
feat: enhance worker deployments with additional packages and CA cert…
patsevanton Nov 19, 2025
02a7e04
feat: enhance worker deployments with additional packages and CA cert…
patsevanton Nov 19, 2025
5a41419
feat: enhance worker deployments with additional packages and CA cert…
patsevanton Nov 19, 2025
18695e8
feat: enhance worker deployments with additional packages and CA cert…
patsevanton Nov 19, 2025
954e415
feat: enhance worker deployments with additional packages and CA cert…
patsevanton Nov 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 24 additions & 3 deletions charts/sentry/templates/sentry/web/deployment-sentry-web.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,10 +80,20 @@ spec:
- name: {{ .Chart.Name }}-web
image: "{{ template "sentry.image" . }}"
imagePullPolicy: {{ default "IfNotPresent" .Values.images.sentry.pullPolicy }}
command: ["sentry"]
command: ["/bin/bash", "-c"]
args:
- "run"
- "web"
- |
{{- if .Values.sentry.web.installAdditionalPackages }}
pip install {{ range .Values.sentry.web.installAdditionalPackages }}{{ . }} {{ end }}
{{- end }}
{{- if .Values.sentry.web.caCertificatesSecret }}
mkdir -p /usr/local/share/ca-certificates/
for c in $(ls -1 /usr/local/share/ca-certificates/); do
cat /usr/local/share/ca-certificates/$c >> $(python3 -m certifi) && echo >> $(python3 -m certifi)
done
update-ca-certificates
{{- end }}
sentry run web
Comment on lines +85 to +96
Copy link

@honghainguyen777 honghainguyen777 Nov 20, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I understand correctly about /bin/bash -c, it accepts exactly one argument. All the arguments after the first one will be ignored (well not really ignored but these args will be assigned to $0, $1, ...).

# Example
command: ["/bin/bash", "-c"]
args:
  - |
    sentry run web
  - "--workers"
  - "4"

$0 = --workers and $1 = 4, but sentry run web (or the whole first string) doesn’t use $0 or $1, so those args don’t get passed to it.

To make it work, you have to have:

        command: ["/bin/bash", "-c"]
        args:
          - |
            {{- if .Values.sentry.web.installAdditionalPackages }}
            pip install {{ range .Values.sentry.web.installAdditionalPackages }}{{ . }} {{ end }}
            {{- end }}
            {{- if .Values.sentry.web.caCertificatesSecret }}
            mkdir -p /usr/local/share/ca-certificates/
            for c in $(ls -1 /usr/local/share/ca-certificates/); do
                cat /usr/local/share/ca-certificates/$c >> $(python3 -m certifi) && echo >> $(python3 -m certifi)
            done
            update-ca-certificates
            {{- end }}
            sentry run web {{- if .Values.sentry.web.workers }} --workers {{ .Values.sentry.web.workers }}{{- end }}{{- if .Values.sentry.web.logLevel }} --loglevel {{ .Values.sentry.web.logLevel }}{{- end }}{{- if .Values.sentry.web.logFormat }} --logformat {{ .Values.sentry.web.logFormat }}{{- end }}

You may want to add set -euo pipefail so the container fails fast on errors.

{{- if .Values.sentry.web.workers }}
- "--workers"
- "{{ .Values.sentry.web.workers }}"
Expand Down Expand Up @@ -131,6 +141,11 @@ spec:
- name: custom-ca
mountPath: /etc/pki/ca-trust/custom
{{ end }}
{{- if .Values.sentry.web.caCertificatesSecret }}
- name: ca-certificates
mountPath: /usr/local/share/ca-certificates
readOnly: true
{{- end }}
{{- if .Values.sentry.web.volumeMounts }}
{{ toYaml .Values.sentry.web.volumeMounts | indent 8 }}
{{- end }}
Expand Down Expand Up @@ -209,4 +224,10 @@ spec:
{{- if .Values.global.volumes }}
{{ toYaml .Values.global.volumes | indent 6 }}
{{- end }}
{{- if .Values.sentry.web.caCertificatesSecret }}
- name: ca-certificates
secret:
secretName: {{ .Values.sentry.web.caCertificatesSecret }}
defaultMode: 0644
{{- end }}
{{- end }}
27 changes: 24 additions & 3 deletions charts/sentry/templates/sentry/worker/deployment-sentry-worker-events.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,10 +78,20 @@ spec:
- name: {{ .Chart.Name }}-worker
image: "{{ template "sentry.image" . }}"
imagePullPolicy: {{ default "IfNotPresent" .Values.images.sentry.pullPolicy }}
command: ["sentry"]
command: ["/bin/bash", "-c"]
args:
- "run"
- "worker"
- |
{{- if .Values.sentry.workerEvents.installAdditionalPackages }}
pip install {{ range .Values.sentry.workerEvents.installAdditionalPackages }}{{ . }} {{ end }}
{{- end }}
{{- if .Values.sentry.workerEvents.caCertificatesSecret }}
mkdir -p /usr/local/share/ca-certificates/
for c in $(ls -1 /usr/local/share/ca-certificates/); do
cat /usr/local/share/ca-certificates/$c >> $(python3 -m certifi) && echo >> $(python3 -m certifi)
done
update-ca-certificates
{{- end }}
sentry run worker
Comment on lines +83 to +94
Copy link

@honghainguyen777 honghainguyen777 Nov 20, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the first comment

- "-Q"
- {{ .Values.sentry.workerEvents.queues }}
{{- if .Values.sentry.workerEvents.concurrency }}
Expand Down Expand Up @@ -122,6 +132,11 @@ spec:
- name: sentry-google-cloud-key
mountPath: /var/run/secrets/google
{{ end }}
{{- if .Values.sentry.workerEvents.caCertificatesSecret }}
- name: ca-certificates
mountPath: /usr/local/share/ca-certificates
readOnly: true
{{- end }}
{{- if .Values.sentry.workerEvents.volumeMounts }}
{{ toYaml .Values.sentry.workerEvents.volumeMounts | indent 8 }}
{{- end }}
Expand Down Expand Up @@ -182,4 +197,10 @@ spec:
{{- if .Values.sentry.workerEvents.volumes }}
{{ toYaml .Values.sentry.workerEvents.volumes | indent 6 }}
{{- end }}
{{- if .Values.sentry.workerEvents.caCertificatesSecret }}
- name: ca-certificates
secret:
secretName: {{ .Values.sentry.workerEvents.caCertificatesSecret }}
defaultMode: 0644
{{- end }}
{{- end }}
27 changes: 24 additions & 3 deletions charts/sentry/templates/sentry/worker/deployment-sentry-worker-transactions.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,10 +78,20 @@ spec:
- name: {{ .Chart.Name }}-worker
image: "{{ template "sentry.image" . }}"
imagePullPolicy: {{ default "IfNotPresent" .Values.images.sentry.pullPolicy }}
command: ["sentry"]
command: ["/bin/bash", "-c"]
args:
- "run"
- "worker"
- |
{{- if .Values.sentry.workerTransactions.installAdditionalPackages }}
pip install {{ range .Values.sentry.workerTransactions.installAdditionalPackages }}{{ . }} {{ end }}
{{- end }}
{{- if .Values.sentry.workerTransactions.caCertificatesSecret }}
mkdir -p /usr/local/share/ca-certificates/
for c in $(ls -1 /usr/local/share/ca-certificates/); do
cat /usr/local/share/ca-certificates/$c >> $(python3 -m certifi) && echo >> $(python3 -m certifi)
done
update-ca-certificates
{{- end }}
sentry run worker
Comment on lines +83 to +94
Copy link

@honghainguyen777 honghainguyen777 Nov 20, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the first comment

- "-Q"
- {{ .Values.sentry.workerTransactions.queues }}
{{- if .Values.sentry.workerTransactions.concurrency }}
Expand Down Expand Up @@ -122,6 +132,11 @@ spec:
- name: sentry-google-cloud-key
mountPath: /var/run/secrets/google
{{ end }}
{{- if .Values.sentry.workerTransactions.caCertificatesSecret }}
- name: ca-certificates
mountPath: /usr/local/share/ca-certificates
readOnly: true
{{- end }}
{{- if .Values.sentry.workerTransactions.volumeMounts }}
{{ toYaml .Values.sentry.workerTransactions.volumeMounts | indent 8 }}
{{- end }}
Expand Down Expand Up @@ -182,4 +197,10 @@ spec:
{{- if .Values.sentry.workerTransactions.volumes }}
{{ toYaml .Values.sentry.workerTransactions.volumes | indent 6 }}
{{- end }}
{{- if .Values.sentry.workerTransactions.caCertificatesSecret }}
- name: ca-certificates
secret:
secretName: {{ .Values.sentry.workerTransactions.caCertificatesSecret }}
defaultMode: 0644
{{- end }}
{{- end }}
27 changes: 24 additions & 3 deletions charts/sentry/templates/sentry/worker/deployment-sentry-worker.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,10 +78,20 @@ spec:
- name: {{ .Chart.Name }}-worker
image: "{{ template "sentry.image" . }}"
imagePullPolicy: {{ default "IfNotPresent" .Values.images.sentry.pullPolicy }}
command: ["sentry"]
command: ["/bin/bash", "-c"]
args:
- "run"
- "worker"
- |
{{- if .Values.sentry.worker.installAdditionalPackages }}
pip install {{ range .Values.sentry.worker.installAdditionalPackages }}{{ . }} {{ end }}
{{- end }}
{{- if .Values.sentry.worker.caCertificatesSecret }}
mkdir -p /usr/local/share/ca-certificates/
for c in $(ls -1 /usr/local/share/ca-certificates/); do
cat /usr/local/share/ca-certificates/$c >> $(python3 -m certifi) && echo >> $(python3 -m certifi)
done
update-ca-certificates
{{- end }}
sentry run worker
Comment on lines +83 to +94
Copy link

@honghainguyen777 honghainguyen777 Nov 20, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the first comment

{{- if .Values.sentry.worker.excludeQueues }}
- "--exclude-queues"
- "{{ .Values.sentry.worker.excludeQueues }}"
Expand Down Expand Up @@ -129,6 +139,11 @@ spec:
- name: sentry-google-cloud-key
mountPath: /var/run/secrets/google
{{ end }}
{{- if .Values.sentry.worker.caCertificatesSecret }}
- name: ca-certificates
mountPath: /usr/local/share/ca-certificates
readOnly: true
{{- end }}
{{- if .Values.sentry.worker.volumeMounts }}
{{ toYaml .Values.sentry.worker.volumeMounts | indent 8 }}
{{- end }}
Expand Down Expand Up @@ -195,4 +210,10 @@ spec:
{{- if .Values.global.volumes }}
{{ toYaml .Values.global.volumes | indent 6 }}
{{- end }}
{{- if .Values.sentry.worker.caCertificatesSecret }}
- name: ca-certificates
secret:
secretName: {{ .Values.sentry.worker.caCertificatesSecret }}
defaultMode: 0644
{{- end }}
{{- end }}
20 changes: 20 additions & 0 deletions charts/sentry/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -294,6 +294,11 @@ sentry:
volumes: []
volumeMounts: []
# workers: 3
# installAdditionalPackages:
# - django-multidb-router
# - sentry-nodestore-elastic
# - https://github.com/pavels/sentry-s3-nodestore/releases/download/v1.0.3/sentry-s3-nodestore-1.0.3.tar.gz
# caCertificatesSecret: ca-certificates # kubectl create secret generic ca-certificates --from-file=you-certificates.crt --namespace=namespace

features:
orgSubdomains: false
Expand Down Expand Up @@ -350,6 +355,11 @@ sentry:
topologySpreadConstraints: []
volumes: []
volumeMounts: []
# installAdditionalPackages:
# - django-multidb-router
# - sentry-nodestore-elastic
# - https://github.com/pavels/sentry-s3-nodestore/releases/download/v1.0.3/sentry-s3-nodestore-1.0.3.tar.gz
# caCertificatesSecret: ca-certificates # kubectl create secret generic ca-certificates --from-file=you-certificates.crt --namespace=namespace

# allows to dedicate some workers to specific queues
workerEvents:
Expand Down Expand Up @@ -390,6 +400,11 @@ sentry:
topologySpreadConstraints: []
volumes: []
volumeMounts: []
# installAdditionalPackages:
# - django-multidb-router
# - sentry-nodestore-elastic
# - https://github.com/pavels/sentry-s3-nodestore/releases/download/v1.0.3/sentry-s3-nodestore-1.0.3.tar.gz
# caCertificatesSecret: ca-certificates # kubectl create secret generic ca-certificates --from-file=you-certificates.crt --namespace=namespace

# allows to dedicate some workers to specific queues
workerTransactions:
Expand Down Expand Up @@ -428,6 +443,11 @@ sentry:
topologySpreadConstraints: []
volumes: []
volumeMounts: []
# installAdditionalPackages:
# - django-multidb-router
# - sentry-nodestore-elastic
# - https://github.com/pavels/sentry-s3-nodestore/releases/download/v1.0.3/sentry-s3-nodestore-1.0.3.tar.gz
# caCertificatesSecret: ca-certificates # kubectl create secret generic ca-certificates --from-file=you-certificates.crt --namespace=namespace

ingestConsumerAttachments:
enabled: true
Expand Down