fix(sentry/sentry/helper): Redis URL not set when using externalRedis.existingSecret or redis.auth.existingSecret

[jiriks74]

Fixes: #1870

[jiriks74]

Hello, seems like this might've been missed. Can I do something to push this further?

[patsevanton]

@jiriks74 could you share minimal values.yaml for reproduce?

[jiriks74]

redis:
  enabled: false
externalRedis:
  host: "my-redis"
  port: 6379
  existingSecret: redis-secret
  existingSecretKey: REDIS_PASSWORD
  db: 0
  ssl: false

[jiriks74]

The issue can be seen in the if statement..

1. Case: RabbitMQ
2. Case: Password defined in values

   {{- else if $redisPass }}

3. Case: No password

   {{- else if and (not .Values.externalRedis.existingSecret) (not .Values.redis.auth.existingSecret)}}

There's a missing case for when either externalRedis.existingSecret or redis.auth.existingSecret is set. And because the 3rd case is an if and on those values, once you set at least one of those the broker URL completely disappears and the workers try to connect to localhost instead.

[jiriks74]

@patsevanton
Anything I can do to push this further? This should solve the problem and the solution takes advantage of variables set up by other templates so it's even not that big of a change. Is there something I'm missing?

[patsevanton]

Need someone to check your MR. I'll try to take the time for that.

[patsevanton]

i tested issue #1870 and not reproducible

[jiriks74]

I'll look into this again in the coming days.