Skip to content

Conversation

TartanLeGrand
Copy link
Contributor

@TartanLeGrand TartanLeGrand commented Jul 29, 2025

🎯 Objective

Reorganize and optimize Sentry feature configuration in the Helm chart template for better maintainability and conditional feature management.

📋 Changes Made

  1. Feature Configuration Restructuring
  • Conditional Feature Management: Implemented dynamic feature activation based on values.yaml configuration
  • Eliminated Duplicates: Removed duplicate feature declarations between conditional and always-enabled feature lists
  • Values-Based Control: Added support for granular feature control through sentry.features in values.yaml
  1. Supported Feature Toggles

The following features can now be controlled via values.yaml:

  • orgSubdomains: Organization subdomain ingestion (false by default)
  • enableProfiling: Application profiling features (false by default)
  • enableSessionReplay: Session replay functionality (true by default)
  • enableFeedback: User feedback features (false by default)
  • enableSpan: Span tracking and metrics (false by default)
  • vstsLimitedScopes: VSTS integration scopes (true by default)
  1. Feature Organization by Category
  • Reorganized always-enabled features into logical categories:
  • Core Features: Authentication, authorization, basic functionality
  • Alerting & Monitoring: Alert management, anomaly detection
  • Performance Monitoring: Transaction tracking, metrics, APM
  • AI & Machine Learning: Seer integration, GenAI features
  • Integrations: GitHub, Jira, external service connections
  • UI & Dashboard: Interface improvements, navigation
  • Workflow Engine: Automation and workflow management
  • Specialized Features: Our Logs, mobile tracking, etc.
  1. Code Quality Improvements
  • Enhanced Readability: Clear categorization with descriptive comments
  • Maintainability: Easier to locate and modify specific feature groups
  • No Breaking Changes: Maintains backward compatibility with existing configurations

@TartanLeGrand
Copy link
Contributor Author

Plus I have enabled temporary features by default and we get the new ui 🎊

@Mokto
Copy link
Contributor

Mokto commented Jul 30, 2025

Let me know when it passes tests

@cjcormack
Copy link
Contributor

I am happy to try and help get this mergeable. The thing that I am currently trying to understand is from where the current list of feature flags is coming? Looking in the self-hosted repo, I think that the list wants to be based on:

Going forward, this is probably something that we want to keep synchronised when updating to a new Sentry build.

@TartanLeGrand TartanLeGrand force-pushed the feat/sentry/add-features branch from 4dfc563 to 8814df4 Compare August 19, 2025 13:00
@TartanLeGrand
Copy link
Contributor Author

@cjcormack can you review this ? 😄

@Mokto
Copy link
Contributor

Mokto commented Sep 2, 2025

👋 Hi, @TartanLeGrand,
I detected conflicts against the base branch 🙊
You'll want to sync 🔄 your branch with upstream!

@Mokto Mokto added the conflicts label Sep 2, 2025
@patsevanton
Copy link
Contributor

Could you rebase PR ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants