-
Notifications
You must be signed in to change notification settings - Fork 552
feat: change kafka to redpanda #1771
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
feat: change kafka to redpanda #1771
Conversation
…SASL authentication
# Settings for Kafka. | ||
# See https://github.com/bitnami/charts/tree/master/bitnami/kafka | ||
kafka: | ||
enabled: true | ||
enabled: false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi!
I think the default broker should be set as kafka, changing it would cause every user to lost all the data stored in kafka.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think it will be that much of a big deal, one could lose some unprocessed events in the transition but isn't that's something to be excepted when doing an upgrade anyways?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes I make a guide for upgrade.
auth: | ||
sasl: | ||
enabled: false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
auth: | |
sasl: | |
enabled: false | |
auth: | |
sasl: | |
enabled: false | |
external: | |
enabled: false | |
logging: | |
usageStats: | |
enabled: false |
I suggest disabling external access as I don't think it is necessary and is best left disabled as a security measure.
Also, usage stats sent to Redpanda are enabled by default.
@TartanLeGrand FYI I tried to deploy this changes, first it failed on a wrong authenticationMethod:
When I switched it to none, just to try - it fails on missing certificates:
|
👋 Hi, @TartanLeGrand, |
This pull request introduces support for Redpanda as an alternative to Kafka in the Sentry Helm chart. The changes include adding Redpanda as a dependency, updating templates to handle Redpanda-specific configurations, and modifying default values to enable Redpanda by default while disabling Kafka. Below is a summary of the most important changes grouped by theme.
Dependency Management
Chart.yaml
, with its repository and version specified, and a condition to enable it viaredpanda.enabled
.Template Updates for Redpanda
sentry.kafka.fullname
to use "redpanda" in the name when Redpanda is enabled.Job Hook Adjustments
sentry-db-check.job.yaml
hook to account for Redpanda when checking Kafka Kraft controllers and external Kafka clusters. [1] [2]Default Values
redpanda
section invalues.yaml
with default configurations for Redpanda, including cluster settings, listeners, and authentication. Enabled Redpanda by default and disabled Kafka.