Skip to content

Add serviceaccount for hooks in sentry chart #1704

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Add serviceaccount for hooks in sentry chart #1704

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f20e8e5
Add service account for hooks in sentry chart
PaulFarver Feb 13, 2025
d9153c7
Bump sentry helm chart version
PaulFarver Feb 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion charts/sentry/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ apiVersion: v2
name: sentry
description: A Helm chart for Kubernetes
type: application
version: 26.14.1
version: 26.14.2
appVersion: 25.2.0
dependencies:
- name: memcached
Expand Down
10 changes: 10 additions & 0 deletions charts/sentry/templates/hooks/hooks-serviceaccount.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
{{- if and .Values.hooks.enabled .Values.serviceAccount.enabled -}}
apiVersion: v1
kind: ServiceAccount
metadata:
name: {{ .Values.serviceAccount.name }}-hooks
{{- if .Values.serviceAccount.annotations }}
annotations: {{ toYaml .Values.serviceAccount.annotations | nindent 4 }}
{{- end }}
automountServiceAccountToken: {{ .Values.serviceAccount.automountServiceAccountToken }}
{{- end }}
3 changes: 3 additions & 0 deletions charts/sentry/templates/hooks/sentry-db-check.job.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,9 @@ spec:
{{ toYaml .Values.hooks.dbCheck.podLabels | indent 8 }}
{{- end }}
spec:
{{- if .Values.serviceAccount.enabled }}
serviceAccountName: {{ .Values.serviceAccount.name }}-hooks
{{- end }}
{{- if .Values.hooks.dbCheck.affinity }}
affinity:
{{ toYaml .Values.hooks.dbCheck.affinity | indent 8 }}
Expand Down
3 changes: 3 additions & 0 deletions charts/sentry/templates/hooks/sentry-db-init.job.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,9 @@ spec:
{{ toYaml .Values.hooks.dbInit.podLabels | indent 8 }}
{{- end }}
spec:
{{- if .Values.serviceAccount.enabled }}
serviceAccountName: {{ .Values.serviceAccount.name }}-hooks
{{- end }}
{{- if .Values.hooks.dbInit.affinity }}
affinity:
{{ toYaml .Values.hooks.dbInit.affinity | indent 8 }}
Expand Down
3 changes: 3 additions & 0 deletions charts/sentry/templates/hooks/snuba-db-init.job.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,9 @@ spec:
{{ toYaml .Values.hooks.snubaInit.podLabels | indent 8 }}
{{- end }}
spec:
{{- if .Values.serviceAccount.enabled }}
serviceAccountName: {{ .Values.serviceAccount.name }}-hooks
{{- end }}
{{- if .Values.hooks.snubaInit.affinity }}
affinity:
{{ toYaml .Values.hooks.snubaInit.affinity | indent 8 }}
Expand Down
3 changes: 3 additions & 0 deletions charts/sentry/templates/hooks/snuba-migrate.job.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,9 @@ spec:
{{ toYaml .Values.hooks.snubaMigrate.podLabels | indent 8 }}
{{- end }}
spec:
{{- if .Values.serviceAccount.enabled }}
serviceAccountName: {{ .Values.serviceAccount.name }}-hooks
{{- end }}
{{- if .Values.hooks.snubaInit.affinity }}
affinity:
{{ toYaml .Values.hooks.snubaInit.affinity | indent 8 }}
Expand Down
3 changes: 3 additions & 0 deletions charts/sentry/templates/hooks/user-create.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,9 @@ spec:
{{ toYaml .Values.sentry.worker.podLabels | indent 8 }}
{{- end }}
spec:
{{- if .Values.serviceAccount.enabled }}
serviceAccountName: {{ .Values.serviceAccount.name }}-hooks
{{- end }}
{{- if .Values.hooks.dbInit.affinity }}
affinity:
{{ toYaml .Values.hooks.dbInit.affinity | indent 8 }}
Expand Down