Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add custom labels for ingress #1672

Merged
merged 1 commit into from
Jan 25, 2025

Conversation

ngnix
Copy link
Contributor

@ngnix ngnix commented Jan 22, 2025

Changes:

  • add ability to define custom labels for ingress resource

Proposal:
I use external DNS operator for manage DNS records.
To allow external-dns manage DNS record for specific ingress resource we must create are custom label on ingress resource.

@olegeech-me
Copy link

👍

@patsevanton
Copy link
Contributor

tested with default values:

helm install -n test --wait sentry . --values values.yaml --timeout=1000s 
coalesce.go:237: warning: skipped value for kafka.config: Not a table.
NAME: sentry
LAST DEPLOYED: Sat Jan 25 11:35:42 2025
NAMESPACE: test
STATUS: deployed
REVISION: 1
TEST SUITE: None
NOTES:
* When running upgrades, make sure to give back the `system.secretKey` value.

kubectl -n test get configmap sentry-sentry -o json | grep -m1 -Po '(?<=system.secret-key: )[^\\]*'
k get pod -n test
NAME                                                              READY   STATUS    RESTARTS      AGE
sentry-billing-metrics-consumer-59b89fdcc6-lfxz2                  1/1     Running   0             3m29s
sentry-clickhouse-0                                               1/1     Running   0             21m
sentry-cron-7d8d955b5-jnvdx                                       1/1     Running   1 (20m ago)   21m
sentry-generic-metrics-consumer-6cbf77dd56-98vfq                  1/1     Running   0             3m28s
sentry-ingest-consumer-attachments-69cdd9578b-jdz9l               1/1     Running   0             3m27s
sentry-ingest-consumer-events-668575694c-wqwlh                    1/1     Running   0             3m27s
sentry-ingest-consumer-transactions-6c654ff5cf-9chj4              1/1     Running   0             3m26s
sentry-ingest-monitors-db89f775d-qqfbg                            1/1     Running   0             3m25s
sentry-ingest-occurrences-78466b7d6-kt54k                         1/1     Running   0             3m24s
sentry-ingest-replay-recordings-746f548f94-szprb                  1/1     Running   0             3m23s
sentry-issue-occurrence-consumer-65d7ddc8fc-g7swf                 1/1     Running   0             3m9s
sentry-kafka-controller-0                                         1/1     Running   0             21m
sentry-kafka-controller-1                                         1/1     Running   0             21m
sentry-kafka-controller-2                                         1/1     Running   0             21m
sentry-metrics-consumer-65b4798b6d-shxc4                          1/1     Running   0             3m22s
sentry-nginx-78665d4559-zz7sl                                     1/1     Running   0             21m
sentry-post-process-forward-errors-7db9dd98c-sjqwr                1/1     Running   0             3m22s
sentry-post-process-forward-issue-platform-9fdf6f48-zpgkm         1/1     Running   0             3m21s
sentry-post-process-forward-transactions-64c5548cd6-t4t9f         1/1     Running   0             3m20s
sentry-rabbitmq-0                                                 1/1     Running   0             21m
sentry-relay-5f76f76bb5-vllwd                                     1/1     Running   0             3m5s
sentry-sentry-postgresql-0                                        1/1     Running   0             21m
sentry-sentry-redis-master-0                                      1/1     Running   0             21m
sentry-sentry-redis-replicas-0                                    1/1     Running   0             21m
sentry-snuba-api-6bb8497c44-fx6g5                                 1/1     Running   1 (19m ago)   21m
sentry-snuba-consumer-5d4756499-qmxxc                             1/1     Running   0             3m20s
sentry-snuba-generic-metrics-counters-consumer-6fd69b54b9-m2f7c   1/1     Running   0             3m16s
sentry-snuba-generic-metrics-distributions-consumer-67988bksns4   1/1     Running   0             3m15s
sentry-snuba-generic-metrics-sets-consumer-8fb4f7685-z9btj        1/1     Running   0             3m14s
sentry-snuba-group-attributes-consumer-7589c6f8b7-99q82           1/1     Running   0             3m14s
sentry-snuba-metrics-consumer-7dbc4f78d4-vvpwz                    1/1     Running   0             3m13s
sentry-snuba-outcomes-billing-consumer-5d655dc766-nlp58           1/1     Running   0             3m12s
sentry-snuba-outcomes-consumer-64cd5bd98d-rrd9q                   1/1     Running   0             3m9s
sentry-snuba-replacer-6dbbf449c6-c8867                            1/1     Running   0             3m8s
sentry-snuba-replays-consumer-57f6b8fdf6-gqbhx                    1/1     Running   0             3m11s
sentry-snuba-spans-consumer-6445d7f8dc-tfklj                      1/1     Running   0             3m11s
sentry-snuba-subscription-consumer-events-7964cf8559-h5sfk        1/1     Running   0             3m7s
sentry-snuba-subscription-consumer-metrics-bc9856864-hktrw        1/1     Running   0             3m6s
sentry-snuba-subscription-consumer-transactions-6f6f56959c8hxkz   1/1     Running   0             3m5s
sentry-snuba-transactions-consumer-58bb885f6f-mt6s9               1/1     Running   0             3m10s
sentry-subscription-consumer-events-749bdc8848-r8v7j              1/1     Running   0             3m19s
sentry-subscription-consumer-generic-metrics-cb94467fc-7cp6l      1/1     Running   0             3m18s
sentry-subscription-consumer-metrics-57f496f7b9-msv9t             1/1     Running   0             3m17s
sentry-subscription-consumer-transactions-5689ddbb56-pdsh6        1/1     Running   0             3m17s
sentry-web-5f8bdbdd7f-mdvnp                                       1/1     Running   0             21m
sentry-worker-6f99c5cbdb-jqs7c                                    1/1     Running   1 (20m ago)   21m
sentry-zookeeper-clickhouse-0                                     1/1     Running   0             21m

@Mokto Mokto merged commit 712a469 into sentry-kubernetes:develop Jan 25, 2025
2 of 3 checks passed
@Mokto Mokto mentioned this pull request Jan 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants