-
Notifications
You must be signed in to change notification settings - Fork 527
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(deps)!: sentry update to 24.7.1 #1343
feat(deps)!: sentry update to 24.7.1 #1343
Conversation
bb60739
to
86e9ef5
Compare
bc4cfdb
to
821bf08
Compare
1d33577
to
3e8265e
Compare
LGTM, but IDK why the test does not work ... |
I personally think it was better before when we could configure the topics. Right now with the automated we enforce partition count = 1 everywhere? |
I thinks for the topics we need to make an PR on the official repo 😄 I have revert my perf optimization and I let 3 replicas for the resources 👍 |
Let's make an inherited BC. I go refactor the PR for fix the Nginx before update. 😄 |
3e8265e
to
5c5b6ff
Compare
@Mokto add this to the same major release. |
I'm still against merging such a PR. We should be able to set the partition counts. |
I suggest then to update only the version. 24.8.0 has already been released, and the chart still uses the May release.. |
yeah that makes sense. |
8e00965
to
c191717
Compare
c191717
to
9099e39
Compare
24.8.0 doesn't work because we got an error of ClickHouse. But 24.7.1 does, I intend to migrate to 24.7.1 and fix 24.8.0 with the ClickHouse redesign. 🤔 |
2ee94b2
to
1cba438
Compare
@TartanLeGrand just so that we're clear, you still intend to remove your changes related to |
Hello @Mokto, yes am sure it's related to getsentry/self-hosted#3121. Let to sentry the responsibility of that. |
As I said before, I don't want our users to lose the ability to set custom partition counts. The self-hosted project is different as everything runs on 1 machine. |
Thanks! I think it's ready to be merged? |
FYI there is a security fix in 24.7.1 cf GHSA-fm88-hc3v-3www |
Nop, fail install with this version |
I understand your concerns about managing Kafka partitions, but I believe we should let Sentry handle the topic creation as outlined in their Kafka schemas repository. In my opinion, it's the software's responsibility not the infrastructure's to manage kafka topics provisioning. In a modern software approach, the infrastructure should provide the necessary resources for the software to function properly, while the software takes care of provisioning what it needs to operate efficiently. |
Agreed but right now the software doesn't support it. |
It's now using 24.7.1. |
This PR introduces updates to our Sentry Kubernetes configuration to align with the new features in Sentry 24.7.1. The latest version of Sentry autonomously handles Kafka migrations and topic management, prompting some significant changes in our setup.
Changes:
values.yaml
.📂 Reorganized Chart Directory: Moved charts into a dedicatedcharts
folder to streamline chart linting and testing processes.Issues Addressed:
Issue sentry-nginx Readiness probe failed #1315Pending:
Next Steps:
🧹 To maintain clarity and ease of review, I plan to split these changes into smaller, focused PRs before finalizing the merge.Request for Feedback:
Looking forward to your thoughts and suggestions!