Skip to content

Commit

Permalink
feat: Allow to set max_suspicious_broken_parts in merge_tree settings… (
Browse files Browse the repository at this point in the history
  • Loading branch information
mrouhi13 authored Nov 27, 2023
1 parent 5cc2b0d commit d2f305c
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 1 deletion.
2 changes: 1 addition & 1 deletion clickhouse/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,6 @@ keywords:
name: clickhouse
sources:
- https://github.com/sentry-kubernetes/charts
version: 3.5.0
version: 3.6.0
maintainers:
- name: sentry-kubernetes
1 change: 1 addition & 0 deletions clickhouse/templates/configmap-config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -165,6 +165,7 @@ data:
<parts_to_delay_insert>{{ .Values.clickhouse.configmap.merge_tree.parts_to_delay_insert }}</parts_to_delay_insert>
<parts_to_throw_insert>{{ .Values.clickhouse.configmap.merge_tree.parts_to_throw_insert }}</parts_to_throw_insert>
<max_part_loading_threads>{{ .Values.clickhouse.configmap.merge_tree.max_part_loading_threads }}</max_part_loading_threads>
<max_suspicious_broken_parts>100</max_suspicious_broken_parts>

This comment has been minimized.

Copy link
@DanielMcAssey

DanielMcAssey Nov 29, 2023

Contributor

This is forcing 100, not what is taken from the configuration

</merge_tree>
{{- end }}
</yandex>
Expand Down
2 changes: 2 additions & 0 deletions clickhouse/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -371,6 +371,8 @@ clickhouse:
parts_to_throw_insert: 300
# The maximum number of threads that read parts when ClickHouse starts.
max_part_loading_threads: auto
# If the number of broken parts in a single partition exceeds the max_suspicious_broken_parts value, automatic deletion is denied.
max_suspicious_broken_parts: 100

##
## Web interface for ClickHouse in the Tabix project.
Expand Down

0 comments on commit d2f305c

Please sign in to comment.