Skip to content

Commit

Permalink
Update sentry to 24.1.1 (#1126)
Browse files Browse the repository at this point in the history 
Signed-off-by: Jan Jansen <[email protected]>
  • Loading branch information
@farodin91
farodin91 authored Feb 5, 2024
1 parent a26db6e commit 101502a
Show file tree
Hide file tree
Showing 10 changed files with 11 additions and 378 deletions.
4 changes: 2 additions & 2 deletions sentry/Chart.yaml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,8 @@ apiVersion: v2
name: sentry
description: A Helm chart for Kubernetes
type: application
version: 21.1.0
appVersion: 23.11.2
version: 21.2.0
appVersion: 24.1.1
dependencies:
- name: memcached
repository: oci://registry-1.docker.io/bitnamicharts
Expand Down
6 changes: 2 additions & 4 deletions sentry/templates/configmap-sentry.yaml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -145,14 +145,12 @@ data:
{{- if .Values.sourcemaps.enabled }}
CACHES = {
"default": {
"BACKEND": "django.core.cache.backends.memcached.MemcachedCache",
"BACKEND": "django.core.cache.backends.memcached.PyMemcacheCache",

This comment has been minimized.

Sign in to view

Copy link
@pehlert

pehlert Feb 6, 2024

This does not seem to work correctly, we have e.g. the ingest metrics consumer pod crash with the following stack trace:

16:12:57 [WARNING] sentry: Unable to update option cache for store.use-relay-dsn-sample-rate (key='store.use-relay-dsn-sample-rate')
Traceback (most recent call last):
  File "/usr/local/bin/sentry", line 8, in <module>
    sys.exit(main())
  File "/usr/local/lib/python3.8/site-packages/sentry/runner/__init__.py", line 195, in main
    func(**kwargs)
  File "/usr/local/lib/python3.8/site-packages/click/core.py", line 1157, in __call__
    return self.main(*args, **kwargs)
  File "/usr/local/lib/python3.8/site-packages/click/core.py", line 1078, in main
    rv = self.invoke(ctx)
  File "/usr/local/lib/python3.8/site-packages/click/core.py", line 1688, in invoke
    return _process_result(sub_ctx.command.invoke(sub_ctx))
  File "/usr/local/lib/python3.8/site-packages/click/core.py", line 1688, in invoke
    return _process_result(sub_ctx.command.invoke(sub_ctx))
  File "/usr/local/lib/python3.8/site-packages/click/core.py", line 1434, in invoke
    return ctx.invoke(self.callback, **ctx.params)
  File "/usr/local/lib/python3.8/site-packages/click/core.py", line 783, in invoke
    return __callback(*args, **kwargs)
  File "/usr/local/lib/python3.8/site-packages/click/decorators.py", line 33, in new_func
    return f(get_current_context(), *args, **kwargs)
  File "/usr/local/lib/python3.8/site-packages/sentry/runner/decorators.py", line 69, in inner
    return ctx.invoke(f, *args, **kwargs)
  File "/usr/local/lib/python3.8/site-packages/click/core.py", line 783, in invoke
    return __callback(*args, **kwargs)
  File "/usr/local/lib/python3.8/site-packages/click/decorators.py", line 33, in new_func
    return f(get_current_context(), *args, **kwargs)
  File "/usr/local/lib/python3.8/site-packages/sentry/runner/decorators.py", line 29, in inner
    return ctx.invoke(f, *args, **kwargs)
  File "/usr/local/lib/python3.8/site-packages/click/core.py", line 783, in invoke
    return __callback(*args, **kwargs)
  File "/usr/local/lib/python3.8/site-packages/sentry/runner/commands/run.py", line 528, in metrics_parallel_consumer
    from sentry.sentry_metrics.consumers.indexer.parallel import get_parallel_metrics_consumer
  File "/usr/local/lib/python3.8/site-packages/sentry/sentry_metrics/consumers/indexer/parallel.py", line 28, in <module>
    from sentry.sentry_metrics.consumers.indexer.processing import MessageProcessor
  File "/usr/local/lib/python3.8/site-packages/sentry/sentry_metrics/consumers/indexer/processing.py", line 26, in <module>
    from sentry.sentry_metrics.indexer.postgres.postgres_v2 import PostgresIndexer
  File "/usr/local/lib/python3.8/site-packages/sentry/sentry_metrics/indexer/postgres/postgres_v2.py", line 38, in <module>
    indexer_cache = StringIndexerCache(
  File "/usr/local/lib/python3.8/site-packages/sentry/sentry_metrics/indexer/cache.py", line 51, in __init__
    self.cache = caches[cache_name]
  File "/usr/local/lib/python3.8/site-packages/django/utils/connection.py", line 62, in __getitem__
    conn = self.create_connection(alias)
  File "/usr/local/lib/python3.8/site-packages/sentry_sdk/integrations/django/caching.py", line 108, in sentry_create_connection
    cache = original_create_connection(self, alias)
  File "/usr/local/lib/python3.8/site-packages/django/core/cache/__init__.py", line 44, in create_connection
    return backend_cls(location, params)
  File "/usr/local/lib/python3.8/site-packages/django/core/cache/backends/memcached.py", line 234, in __init__
    import pymemcache.serde
ModuleNotFoundError: No module named 'pymemcache'

This comment has been minimized.

Sign in to view

Copy link
@pehlert

pehlert Feb 6, 2024

Ignore, Helm did not update the container images of said deployments correctly.
"LOCATION": [
"{{ template "sentry.fullname" . }}-memcached:11211"
],
"TIMEOUT": 3600,
"OPTIONS": {
"server_max_value_length": unit_text_to_bytes(env("SENTRY_MAX_EXTERNAL_SOURCEMAP_SIZE", "1M")),
},
"OPTIONS": {"ignore_exc": True}
}
}
import memcache
Expand Down
1 change: 1 addition & 0 deletions sentry/templates/configmap-snuba.yaml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@ data:
"events",
"events_ro",
"metrics",
"metrics_summaries",
"migrations",
"outcomes",
"querylog",
Expand Down
149 changes: 0 additions & 149 deletions sentry/templates/deployment-sentry-ingest-metrics-consumer-perf.yaml
View file

This file was deleted.

149 changes: 0 additions & 149 deletions sentry/templates/deployment-sentry-ingest-metrics-consumer-rh.yaml
View file

This file was deleted.

3 changes: 3 additions & 0 deletions sentry/templates/deployment-sentry-ingest-monitors.yaml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,9 @@ spec:
command: ["sentry"]
args:
- "run"
- "consumer"
- "ingest-monitors"
- "--consumer-group"
- "ingest-monitors"
env:
- name: C_FORCE_ROOT
Expand Down
3 changes: 3 additions & 0 deletions sentry/templates/deployment-sentry-ingest-profiles.yaml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,9 @@ spec:
command: ["sentry"]
args:
- "run"
- "consumer"
- "ingest-profiles"
- "--consumer-group"
- "ingest-profiles"
env:
- name: C_FORCE_ROOT
Expand Down
10 changes: 0 additions & 10 deletions sentry/templates/serviceaccount-sentry-ingest-metrics-consumer-perf.yaml
View file

This file was deleted.

10 changes: 0 additions & 10 deletions sentry/templates/serviceaccount-sentry-ingest-metrics-consumer-rh.yaml
View file

This file was deleted.

Loading

0 comments on commit 101502a

Please sign in to comment.