New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(getPlaylist): populate ArtistID and AlbumID #567

Open

richardsamuels wants to merge 4 commits into sentriz:master from richardsamuels:fix-playlist-fields

+578 −96

richardsamuels commented Feb 24, 2025

The OpenSubsonic getPlaylist spec doc lists artistId and albumId as fields for playlist entries, which are currently not being populated.

This PR populates those fields.

richardsamuels added 4 commits

February 24, 2025 09:07


          fix(playlist): populate ArtistID and AlbumID

ccb9fc5


          update keys for CI lint config

3b720d4


          fix lint config again

a41e210


          fix golden samples

27e4d47

Author

richardsamuels commented Feb 24, 2025

Tests fixed.

The changes to .golangci.yml are to fix this error that popped up. It appears to be caused by an update to your linter action.
The testdata files were not formatted in a readable way after using GONIC_REGEN, so I ran them through jq. This did not match your previous formatting perfectly. Let me know if you have a preferred linter for those files and I can fix them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet