Skip to content

fix: prevent working directory corruption during goofys install #89

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lucabarak wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: prevent working directory corruption during goofys install #89

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions setup.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -533,12 +533,12 @@ install_goofys() {
info "Building goofys from PR #778 (gopsutil v3 fix for Apple Silicon)..."
local temp_dir="/tmp/goofys-build-$$"
mkdir -p "$temp_dir"
cd "$temp_dir"
pushd "$temp_dir" > /dev/null

if git clone -b feature/upgrade-gopsutil https://github.com/chiehting/goofys.git 2>/dev/null; then
cd goofys
pushd goofys > /dev/null
if go install . 2>/dev/null; then
cd - && rm -rf "$temp_dir"
popd > /dev/null && popd > /dev/null && rm -rf "$temp_dir"

# Check if build successful
local goofys_path=""
Expand All @@ -562,7 +562,7 @@ install_goofys() {
fi
fi
fi
cd - && rm -rf "$temp_dir"
popd > /dev/null 2>&1; popd > /dev/null 2>&1; rm -rf "$temp_dir"
warning "Build from source failed"
else
info "Go compiler not found, skipping source build"
Expand Down Expand Up @@ -777,6 +777,9 @@ install_optional_tools() {
select_profile() {
step "Select Configuration Profile"

# Ensure we are in the script directory (guards against cd side effects from tool installs)
cd "$SCRIPT_DIR"

local profiles=($(discover_profiles))

if [ ${#profiles[@]} -eq 0 ]; then
Expand Down