Merge pull request #318 from sensebox/fix/loop-var-init

init var in loop if not previously defined
sensebox · Jul 2, 2024 · a41e5c8 · a41e5c8
2 parents d00deff + 58e3703
commit a41e5c8
Showing 1 changed file with 9 additions and 1 deletion.
diff --git a/src/components/Blockly/generator/loops.js b/src/components/Blockly/generator/loops.js
@@ -36,7 +36,14 @@ Blockly['Arduino']['controls_for'] = function (Block) {
         Block.getFieldValue('VAR')
     ).name;
 
-
+    const allVars = Blockly.getMainWorkspace()
+        .getVariableMap()
+        .getAllVariables();
+    const myVar = allVars.filter((v) => v.name === loopIndexVariable)[0];
+    var initVariable = "";
+    if (Blockly.Arduino.variables_[loopIndexVariable + myVar.type] == undefined) {
+        initVariable = "int "; // alternatively set to 'myVar.type' but that could lead to issues if users choose a char or a boolean
+    }
 
     const branch = Blockly['Arduino'].statementToCode(Block, 'DO');
 
@@ -71,6 +78,7 @@ Blockly['Arduino']['controls_for'] = function (Block) {
 
     return (
         'for (' +
+        initVariable + 
         loopIndexVariable +
         ' = ' +
         startNumber +