Fix presumption in comparision used by 'sum', 'extend', and 'roles' exercises#108
Open
Antony74 wants to merge 5 commits into
Open
Fix presumption in comparision used by 'sum', 'extend', and 'roles' exercises#108Antony74 wants to merge 5 commits into
Antony74 wants to merge 5 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes #106 "Sum Verification Problem"
In fact, it's not just the "sum" problem that is broken, but also "extend" and "roles".
The solution comparision relies on the output of the exercise being identical to the output of the official solution. However, seneca responds with various "meta" fields, such as the timestamps "start" and "end" which can be expected to be different with every call. Presumably these particular "meta" fields did not exist at the time the tutorial was written. To restore desired function and correctly compare the results we pick just the fields from the 'meta' object that do stay the same.
I have sucessfully completed the course, and as such believe I have removed all the bugs preventing students from doing so.