Add Find:Deps Msg #2
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjrodger
requested changes
Dec 9, 2025
dist/Traverse.d.ts
Outdated
| @@ -1,5 +1,12 @@ | |||
| type Entity = string; | |||
Contributor
There was a problem hiding this comment.
since the string is an entity id, may rename this to EntityID
dist/Traverse.d.ts
Outdated
| @@ -1,5 +1,12 @@ | |||
| type Entity = string; | |||
| type Relation = [Entity, Entity]; | |||
Contributor
There was a problem hiding this comment.
it's not just any relation - this is a parent child relation
many rename to ParentChildRelation
| expect(seneca.find_plugin('Traverse')).exist() | ||
| }) | ||
|
|
||
| test('find-deps', async () => { |
Contributor
There was a problem hiding this comment.
add a test for my example in the spec doc using [A,B], etc
Contributor
Author
There was a problem hiding this comment.
Done, I also added test cases with multiple examples for entity IDs:
fff4736
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.