[UIK-3527][color-picker] fixed some color-picker issues #2547
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slizhevskyv-semrush
previously approved these changes
Oct 22, 2025
Valeria-Zimnitskaya
previously approved these changes
Oct 30, 2025
j-mnizhek
reviewed
Oct 30, 2025
Member
j-mnizhek
left a comment
j-mnizhek
left a comment
There was a problem hiding this comment.
Overall everything is good. But I have a proposal for the 2 case based on the correct UX behaviour.
FFFFFF hex is actually valid, but why the input shows that it's not because of the validation rules in this particular example. It maybe with a 99% contrintuitive for the user.
So the question is: can we set different validation rules or at least add a tooltip that explains why the value that I've entered is invalid?
Signed-off-by: ilyabrower <[email protected]>
Valeria-Zimnitskaya
previously approved these changes
Oct 31, 2025
Valeria-Zimnitskaya
approved these changes
Oct 31, 2025
j-mnizhek
approved these changes
Oct 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Fixed UIK-3526, UIK-3527 and UIK-2865
How has this been tested?
Manually
Screenshots (if appropriate):
Types of changes
Checklist:
CHANGELOG.mdfile with planned publish date.