Skip to content

[UIK-4348][data-table] some accordion performance #2540

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 24 commits into from
Oct 24, 2025
Merged

[UIK-4348][data-table] some accordion performance #2540

merged 24 commits into from
Oct 24, 2025

Conversation

@ilyabrower
Copy link
Contributor

@ilyabrower ilyabrower commented Oct 21, 2025

Motivation and Context

How has this been tested?

Manually

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to not work as expected).
  • Nice improve.

Checklist:

  • I have updated the documentation accordingly.
  • I have added changelog note to corresponding CHANGELOG.md file with planned publish date.
  • I have added new tests on added of fixed functionality.

@ilyabrower ilyabrower force-pushed the UIK-4348/data-table-accordion-perf branch from 06648b8 to 84082ec Compare October 22, 2025 13:30
slizhevskyv-semrush
slizhevskyv-semrush previously approved these changes Oct 22, 2025
View reviewed changes
Copy link
Contributor

@slizhevskyv-semrush slizhevskyv-semrush left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, it works like a charm! Just left a few minor comments :)
image

ilyabrower and others added 16 commits October 23, 2025 12:38
j-mnizhek
j-mnizhek approved these changes Oct 24, 2025
View reviewed changes
Copy link
Member

@j-mnizhek j-mnizhek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked locally, works perfectly! 🤩 Nothing to add or comment

@Valeria-Zimnitskaya Valeria-Zimnitskaya merged commit 3a5b031 into release/v16 Oct 24, 2025
7 checks passed
@Valeria-Zimnitskaya Valeria-Zimnitskaya deleted the UIK-4348/data-table-accordion-perf branch October 24, 2025 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@j-mnizhek j-mnizhek j-mnizhek approved these changes

@Valeria-Zimnitskaya Valeria-Zimnitskaya Valeria-Zimnitskaya approved these changes

@slizhevskyv-semrush slizhevskyv-semrush slizhevskyv-semrush left review comments

Assignees

@ilyabrower ilyabrower

Labels

accordion add-filter animation badge base-components base-trigger breadcrumbs breakpoints bulk-textarea button card carousel checkbox color-picker core counter d3-chart data-table date-picker divider dot drag-and-drop dropdown dropdown-menu ellipsis errors feature-highlight feature-popover feedback-form flags flex-box format-text fullscreen-modal grid i18n-unplugin icon illustration inline-edit inline-input input input-mask input-number input-tags link mini-chart modal neighbor-location notice notice-bubble notice-global outside-click pagination pills popper portal product-head progress-bar radio scroll-area select side-panel skeleton slider spin spin-container sticky switch tab-line tab-panel tag textarea time-picker tooltip typography widget-empty wizard

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@ilyabrower @j-mnizhek @Valeria-Zimnitskaya @slizhevskyv-semrush