Skip to content

[UIK-4022][data-table] fixed spinner height, depending on scrolling #2530

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 23, 2025
Merged

[UIK-4022][data-table] fixed spinner height, depending on scrolling #2530

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c154d07
[data-table] fixed spinner height, depending on scrolling
ilyabrower Oct 16, 2025
7ec41cc
[data-table] fixed spinner offset for table with sticky header
ilyabrower Oct 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 21 additions & 4 deletions semcore/data-table/src/components/Body/Body.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,14 +148,33 @@ class BodyRoot<Data extends DataTableData, UniqKeyType> extends Component<DataTa
};
}

getSpinnerTopOffset = () => {
const { headerHeight: propsHeaderHeight, tableContainerRef, stickyHeader } = this.asProps;

let headerHeight = propsHeaderHeight;

if (stickyHeader) {
return headerHeight;
}

if (tableContainerRef.current) {
if (tableContainerRef.current.scrollTop > headerHeight) {
headerHeight = 0;
} else {
headerHeight = headerHeight - tableContainerRef.current.scrollTop;
}
}

return headerHeight;
};

render() {
const SBody = Root;
const SRowGroup = Box;
const SSpinContainer = Box;
const {
styles,
loading,
headerHeight,
spinnerRef,
virtualScroll,
scrollDirection,
Expand All @@ -169,8 +188,6 @@ class BodyRoot<Data extends DataTableData, UniqKeyType> extends Component<DataTa
} = this.asProps;

let rowsToRender = rows;
// let startIndex = -1;
// let lastIndex = -1;

if (virtualScroll) {
const rowsBuffer =
Expand Down Expand Up @@ -335,7 +352,7 @@ class BodyRoot<Data extends DataTableData, UniqKeyType> extends Component<DataTa
<SSpinContainer
innerOutline
// @ts-ignore
headerHeight={`${headerHeight}px`}
headerHeight={`${this.getSpinnerTopOffset()}px`}
tabIndex={-1}
ref={spinnerRef}
role='row'
Expand Down
Loading