rename to CMK

some rules use the term "unencrypted" but are actually encrypted with AWS provided keys and are therefore actually encrypted. This change renames several rules to be consistent with "encrypted-with-cmk" terminology.

.gitignore

@@ -4,3 +4,5 @@ __pycache__/
 .DS_Store
 .vscode/
 .venv
+.idea/
+*.iml

terraform/aws/security/aws-cloudwatch-log-group-unencrypted.tf → terraform/aws/security/aws-cloudwatch-log-group-encrypted-with-cmk.tf

@@ -2,7 +2,7 @@ resource "aws_cloudwatch_log_group" "pass" {
   retention_in_days = 1
   kms_key_id        = "someKey"
 }
-# ruleid: aws-cloudwatch-log-group-unencrypted
+# ruleid: aws-cloudwatch-log-group-encrypted-with-cmk
 resource "aws_cloudwatch_log_group" "fail" {
   retention_in_days = 1
 }

terraform/aws/security/aws-cloudwatch-log-group-unencrypted.yaml → terraform/aws/security/aws-cloudwatch-log-group-encrypted-with-cmk.yaml

@@ -1,5 +1,5 @@
 rules:
-- id: aws-cloudwatch-log-group-unencrypted
+- id: aws-cloudwatch-log-group-encrypted-with-cmk
   patterns:
   - pattern: |
       resource "aws_cloudwatch_log_group" $ANYTHING {

terraform/aws/security/aws-lambda-environment-unencrypted.tf → terraform/aws/security/aws-lambda-environment-encrypted-with-cmk.tf

@@ -10,7 +10,7 @@ resource "aws_lambda_function" "fail" {
       mode = "PassThrough"
    }
 
-   # ruleid: aws-lambda-environment-unencrypted
+   # ruleid: aws-lambda-environment-encrypted-with-cmk
    environment {
       test="true"
    }
@@ -26,7 +26,7 @@ resource "aws_lambda_function" "failkmsnovars" {
    tracing_config {
        mode = "PassThrough"
     }
-   # ruleid: aws-lambda-environment-unencrypted
+   # ruleid: aws-lambda-environment-encrypted-with-cmk
    kms_key_arn = aws_kms_key.anyoldguff.arn
 }
 
@@ -70,6 +70,6 @@ resource "aws_lambda_function" "failasempty" {
    tracing_config {
        mode = "PassThrough"
     }
-   # ruleid: aws-lambda-environment-unencrypted
+   # ruleid: aws-lambda-environment-encrypted-with-cmk
    kms_key_arn = ""
 }

terraform/aws/security/aws-lambda-environment-unencrypted.yaml → terraform/aws/security/aws-lambda-environment-encrypted-with-cmk.yaml

@@ -1,5 +1,5 @@
 rules:
-- id: aws-lambda-environment-unencrypted
+- id: aws-lambda-environment-encrypted-with-cmk
   patterns:
   - pattern-inside: |
       resource "aws_lambda_function" $ANYTHING {

terraform/aws/security/aws-secretsmanager-secret-unencrypted.tf → terraform/aws/security/aws-secretsmanager-secret-encrypted-with-cmk.tf

@@ -13,7 +13,7 @@ resource "aws_secretsmanager_secret" "enabled2" {
 }
 
 # failure
-# ruleid: aws-secretsmanager-secret-unencrypted
+# ruleid: aws-secretsmanager-secret-with-cmk
 resource "aws_secretsmanager_secret" "default" {
   name = "secret"
 }

terraform/aws/security/aws-secretsmanager-secret-unencrypted.yaml → terraform/aws/security/aws-secretsmanager-secret-encrypted-with-cmk.yaml

@@ -1,5 +1,5 @@
 rules:
-- id: aws-secretsmanager-secret-unencrypted
+- id: aws-secretsmanager-secret-encrypted-with-cmk
   patterns:
   - pattern: |
       resource "aws_secretsmanager_secret" $ANYTHING {