Use project ID for API calls if available #809
Conversation
fgreinacher
force-pushed
the
fix/project-id
branch
from
6bd91f8 to
743ab0a
Compare
There was a problem hiding this comment.
Copilot reviewed 6 out of 14 changed files in this pull request and generated no comments.
Files not reviewed (8)
- test/get-repo-id.test.js: Evaluated as low risk
- test/publish.test.js: Evaluated as low risk
- lib/success.js: Evaluated as low risk
- lib/fail.js: Evaluated as low risk
- lib/definitions/errors.js: Evaluated as low risk
- lib/publish.js: Evaluated as low risk
- test/integration.test.js: Evaluated as low risk
- test/fail.test.js: Evaluated as low risk
fgreinacher
force-pushed
the
fix/project-id
branch
from
c7efd3b to
2102ec3
Compare
There was a problem hiding this comment.
Copilot reviewed 5 out of 13 changed files in this pull request and generated no comments.
Files not reviewed (8)
- test/get-repo-id.test.js: Evaluated as low risk
- lib/get-repo-id.js: Evaluated as low risk
- test/publish.test.js: Evaluated as low risk
- lib/success.js: Evaluated as low risk
- lib/fail.js: Evaluated as low risk
- lib/definitions/errors.js: Evaluated as low risk
- test/integration.test.js: Evaluated as low risk
- lib/publish.js: Evaluated as low risk
Comments suppressed due to low confidence (1)
test/get-project-context.test.js:6
- The URL 'https://gitlbab.com' seems to be a typo. It should be 'https://gitlab.com'.
getProjectContext({ env: {} }, "https://gitlbab.com", "https://api.gitlab.com", "https://gitlab.com/owner/repo.git")
|
@JonasSchubert Would you have a look at this? 🙇 |
Sure @fgreinacher |
There was a problem hiding this comment.
Thanks @fgreinacher I like the implementation a lot and also thanks for providing the commits as your train of thoughts. Helped a lot!
Beside one question regarding exposing a variable, and the pre-existing typo it looks good to me.
|
🎉 This PR is included in version 13.2.4 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This MR safely implements the suggestion from #580 (comment).
If
CI_PROJECT_IDis available it will be used for accessing API resources. If it is not the previous logic to useCI_PROJECT_PATHwill apply.I'd suggest to review this commit-by-commit to be able to follow my train of thought.
Closes #543